Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize pulse amplitude meaning #1006

Closed
stavros11 opened this issue Aug 26, 2024 · 2 comments · Fixed by #1010
Closed

Standardize pulse amplitude meaning #1006

stavros11 opened this issue Aug 26, 2024 · 2 comments · Fixed by #1010
Assignees
Milestone

Comments

@stavros11
Copy link
Member

stavros11 commented Aug 26, 2024

The initial idea in 0.1 was that amplitude is dimensionless in [-1, 1]. However, when I implemented the QM driver, I treated it as raw voltage, essentially limiting it to [-0.5, 0.5] as per instrument specifications.

We should properly define its meaning for 0.2, as this is essentially part of the interface, and update the QM driver accordingly, so that all instruments behave consistently in the future. The update should be easy, for QM it should be sufficient to divide all waveform samples by 2 before uploading to the instrument.

@alecandido @andrea-pasquale in case you are interested and have any suggestion.

@stavros11 stavros11 added this to the Qibolab 0.2.0 milestone Aug 26, 2024
@andrea-pasquale
Copy link
Contributor

For sure it would be interested to map the amplitude to volts. I'm in favour of standardizing everything between [-1,1] and later think about a way to map this dimensionless quantity to something measurable (like volts).
For characterization purposes, at least when dealing with flux pulses it might be more interesting to map the amplitude directly to the detuning on the qubit frequency (I'm currently working on something like this).

@alecandido
Copy link
Member

I'm also in favor of standardizing everything to [-1, 1], a map has to be calibrated anyhow, since in most cases the instrument API is not giving many guarantees about voltages, and it could just use arbitrary units.

However, while this will change the calibrated values, it's not really affecting the interface (though it's breaking, for sure). So, better doing it soon

For characterization purposes, at least when dealing with flux pulses it might be more interesting to map the amplitude directly to the detuning on the qubit frequency (I'm currently working on something like this).

This could be a double map, since for switching instruments voltages are more decoupled, and they should be more reliable (the corresponding detuning may even change over time...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants