Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inability to fully build pony on Raspberry PI 4's with 64-bit Raspbian #3949

Merged
merged 4 commits into from
Dec 21, 2021

Conversation

chalcolith
Copy link
Member

@chalcolith chalcolith commented Dec 21, 2021

…lation

- Adds a Makefile variable `pic_flag` that you can set to either `-fpic` or `-fPIC` for both `make libs` and `make configure`
- On `aarch64`, the variable will default to `-fPIC` for `make libs` and `make configure` (see #3870); on other Unix architectures it will be set to `-fpic`.

Fixes #3870
@chalcolith
Copy link
Member Author

I haven't been able to figure out a way to detect that we're on raspbian from cmake or the shell; still investigating...

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Dec 21, 2021
@ponylang-main
Copy link
Contributor

Hi @kulibali,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3949.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen SeanTAllen changed the title Add a way of specifying either the -fpic or -fPIC flags for compilation Fix inability to fully build pony on Raspberry PI 4's with 64-bit Raspbian Dec 21, 2021
@SeanTAllen SeanTAllen merged commit 43e61bf into main Dec 21, 2021
@SeanTAllen SeanTAllen deleted the kulibali/issue_3870_pic_flags branch December 21, 2021 21:46
github-actions bot pushed a commit that referenced this pull request Dec 21, 2021
github-actions bot pushed a commit that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build libponyc.tests on Raspberry PI 4 with Raspbian 64-bit
4 participants