Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build instructions for 64-bit Raspbian #3880

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

SeanTAllen
Copy link
Member

Closes #3872

@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Oct 3, 2021
@SeanTAllen SeanTAllen requested review from chalcolith and a team October 3, 2021 22:50
@SeanTAllen
Copy link
Member Author

This should be updated with the instructions that include whatever comes out of #3870 before merging.

@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Oct 3, 2021
@SeanTAllen SeanTAllen force-pushed the raspbian64-build-instructions branch 2 times, most recently from c534700 to 497d017 Compare October 6, 2021 03:20
@SeanTAllen SeanTAllen force-pushed the raspbian64-build-instructions branch from 497d017 to 340c1f9 Compare October 6, 2021 03:35
Copy link
Member

@chalcolith chalcolith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3949 automatically sets -fPIC for aarch64, so no changes are needed.

@SeanTAllen
Copy link
Member Author

SeanTAllen commented Dec 21, 2021

So, we don't currently use -fPIC on gravitron so that would be a change there @kulibali. I don't think we need for all aarch64. Is gravitron not aarch64? I don't think we want that on for gravitron if its not needed. At least not as an "always on".

@chalcolith
Copy link
Member

I haven't been able to find a way to detect Raspbian from cmake or the shell -- still trying to figure out how.

@SeanTAllen
Copy link
Member Author

@kulibali I personally think it would be fine to have build instructions that say "hey for X, you need to use Y" and leave the raspbian64 at that.

@chalcolith
Copy link
Member

OK, I have updated #3949 to not try to change the pic flag, so the instructions should say to use make libs pic_flag=-fPIC and make configure pic_flag=-fPIC.

@SeanTAllen
Copy link
Member Author

@kulibali so pic_flag=-fPIC isn't needed on the build command?

@chalcolith
Copy link
Member

@SeanTAllen correct; the build flags are baked into makefiles by make configure, and make build calls make on those makefiles.

@SeanTAllen SeanTAllen merged commit 9322d31 into main Dec 21, 2021
@SeanTAllen SeanTAllen deleted the raspbian64-build-instructions branch December 21, 2021 21:47
github-actions bot pushed a commit that referenced this pull request Dec 21, 2021
github-actions bot pushed a commit that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge do not merge This PR should not be merged at this time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build ponyc on Raspbian 64-bit with clang
3 participants