Add extra_args to modules meta-schema.json #7783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
awgymer
reviewed
Mar 13, 2025
| @@ -34,6 +34,19 @@ | |||
| "type": "string" | |||
| } | |||
| }, | |||
| "extra_args": { | |||
| "type": "array", | |||
There was a problem hiding this comment.
The current implementation in tools that I used was an object/map:
extra_args:
args:
description: 'samtools index'I found this reduced the duplication/nesting of the fields and felt more intuitive to write.
There was a problem hiding this comment.
oh ok, I missed that. But maybe we should make it an array, to be consistent with the other sections: tools, input, output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close tools issue nf-core/tools#3444
Required for tools PR nf-core/tools#3451
Related to website PR nf-core/website#3041