Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): introduce intrinsic exception #14182

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Tiny enhancement

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Base exception filters won't auto-log intrinsic errors. So far, this has been the default behavior only for HttpException errors

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0437aad1-7980-44fc-9973-959c535010f9

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 90.109%

Totals Coverage Status
Change from base Build e0bf29f0-9145-4934-8bf2-9c17fbcadc0d: 0.004%
Covered Lines: 6969
Relevant Lines: 7734

💛 - Coveralls

*
* @publicApi
*/
export class IntrinsicException extends Error {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been trying to mimic what we had so far for the HttpException
image

@kamilmysliwiec kamilmysliwiec merged commit b04895a into 11.0.0 Nov 22, 2024
3 checks passed
@kamilmysliwiec kamilmysliwiec mentioned this pull request Nov 22, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants