-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiUSMesh fixes and test #66
Conversation
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
===========================================
+ Coverage 45.72% 73.43% +27.71%
===========================================
Files 6 6
Lines 748 753 +5
===========================================
+ Hits 342 553 +211
+ Misses 406 200 -206
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything here looks good
Purpose
MultiUSMesh was not used or tested, so it broke in several ways over the years. The main fixes here are related to imports, file I/O, and cgns_utils.
I also bumped the version number, and I will make a new release once this is merged.
Type of change
Testing
I added a test using the Onera M6 mesh from the MACH-Aero overset tutorial. The test follows the same structure as the USMesh tests:
One of the mesh warping instances uses non-default
aExp
andbExp
, which adds test coverage for the feature added in #64. I took this opportunity to test a bunch of other non-default options as well.Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted