Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiUSMesh fixes and test #66

Merged
merged 15 commits into from
Mar 14, 2022
Merged

MultiUSMesh fixes and test #66

merged 15 commits into from
Mar 14, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Feb 18, 2022

Purpose

MultiUSMesh was not used or tested, so it broke in several ways over the years. The main fixes here are related to imports, file I/O, and cgns_utils.

I also bumped the version number, and I will make a new release once this is merged.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

I added a test using the Onera M6 mesh from the MACH-Aero overset tutorial. The test follows the same structure as the USMesh tests:

  1. Regression testing the initial and warped coordinates
  2. Complex-step verification of the AD

One of the mesh warping instances uses non-default aExp and bExp, which adds test coverage for the feature added in #64. I took this opportunity to test a bunch of other non-default options as well.

Checklist

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner February 18, 2022 16:17
@sseraj sseraj requested review from lamkina and awccopp February 18, 2022 16:17
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #66 (3367f42) into master (71640df) will increase coverage by 27.71%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #66       +/-   ##
===========================================
+ Coverage   45.72%   73.43%   +27.71%     
===========================================
  Files           6        6               
  Lines         748      753        +5     
===========================================
+ Hits          342      553      +211     
+ Misses        406      200      -206     
Impacted Files Coverage Δ
idwarp/MultiUnstructuredMesh_C.py 91.66% <ø> (+41.66%) ⬆️
idwarp/UnstructuredMesh.py 62.73% <ø> (+1.65%) ⬆️
idwarp/MultiUnstructuredMesh.py 84.61% <92.85%> (+76.38%) ⬆️
idwarp/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71640df...3367f42. Read the comment docs.

Copy link

@lamkina lamkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Copy link

@awccopp awccopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good

@marcomangano
Copy link
Contributor

@awccopp @lamkina feel free to go ahead and merge

@sseraj sseraj merged commit a1f6b31 into mdolab:master Mar 14, 2022
@sseraj sseraj deleted the multi-fix branch March 14, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants