-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented aExp and bExp options #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 45.80% 44.78% -1.02%
==========================================
Files 6 6
Lines 751 748 -3
==========================================
- Hits 344 335 -9
- Misses 407 413 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This will be very useful.
Thank you @sseraj!
As discussed during the maintenance meeting, a test will be added in an upcoming PR |
@eirikurj @SichengHe could you take a look at this some time? It would be really helpful to get this feature merged. |
@SichengHe @eirikurj. Just another reminder, as I would also like to get this feature on the main branch ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything here looks good to me.
Purpose
Closes #40. Please see the issue for some discussion on the performance penalty compared to hard-coded values for the exponents.
Type of change
Testing
I plan to add a test with non-default exponents in a subsequent PR where I will add a test for MultiUSMesh.
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted