Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): revert bool to boolValue PR #13057

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Mar 11, 2025

Motivation

We only need mesh resource revert.

Seems that syncing is broken:

type: Mesh
name: default
mtls:
  enabledBackend: ca-1
  backends:
    - name: ca-1
      type: builtin
      dpCert:
        rotation:
          expiration: 1d
networking:
  outbound:
    passthrough: false
routing:
  localityAwareLoadBalancing: true
  zoneEgress: true

becomes:

  spec:
    mtls:
      backends:
        - dpCert:
          rotation:
            expiration: 1d
        name: ca-1
        type: builtin
      enabledBackend: ca-1
    networking:
      outbound:
        passthrough: false
    routing: {}

on the zone

Implementation information

revert Mesh part of #12895

@slonka slonka requested a review from a team as a code owner March 11, 2025 14:42
@slonka slonka requested review from jijiechen and Icarus9913 March 11, 2025 14:42
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@slonka slonka marked this pull request as draft March 11, 2025 14:52
@slonka slonka force-pushed the revert-pr-adjust-resources branch from d8c2c37 to 1a26876 Compare March 11, 2025 15:07
@slonka slonka requested review from lobkovilya and lukidzi March 11, 2025 15:07
@slonka slonka marked this pull request as ready for review March 11, 2025 15:09
@slonka
Copy link
Contributor Author

slonka commented Mar 11, 2025

Tested locally (left is zone):

image

@slonka slonka merged commit 81b8e4c into kumahq:release-2.10 Mar 11, 2025
13 checks passed
gnana997 pushed a commit to gnana997/kuma that referenced this pull request Mar 12, 2025
## Motivation

**We only need `mesh` resource revert.**

Seems that syncing is broken:

```
type: Mesh
name: default
mtls:
  enabledBackend: ca-1
  backends:
    - name: ca-1
      type: builtin
      dpCert:
        rotation:
          expiration: 1d
networking:
  outbound:
    passthrough: false
routing:
  localityAwareLoadBalancing: true
  zoneEgress: true
```

becomes:

```
  spec:
    mtls:
      backends:
        - dpCert:
          rotation:
            expiration: 1d
        name: ca-1
        type: builtin
      enabledBackend: ca-1
    networking:
      outbound:
        passthrough: false
    routing: {}
```

on the zone

## Implementation information

revert Mesh part of kumahq#12895

---------

Signed-off-by: slonka <[email protected]>
Signed-off-by: gnana997 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants