Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back bool => boolValue change on Mesh resource #13058

Open
slonka opened this issue Mar 11, 2025 · 3 comments
Open

Bring back bool => boolValue change on Mesh resource #13058

slonka opened this issue Mar 11, 2025 · 3 comments
Labels
triage/needs-information Reviewed and some extra information was asked to the reporter

Comments

@slonka
Copy link
Contributor

slonka commented Mar 11, 2025

Description

#12895 broke syncing of Mesh. We reverted only Mesh related change here #13057 and we need to figure out how to safely transition bool => boolValue (or keep the workaround with SupressZeroNullModifier we can't keep the modifier workaround because it doesn't work).

@slonka slonka added the triage/pending This issue will be looked at on the next triage meeting label Mar 11, 2025
@slonka
Copy link
Contributor Author

slonka commented Mar 17, 2025

The reason this did not work is that we still send proto over the wire

if msg, ok := spec.(proto.Message); ok {
return util_proto.UnmarshalAnyTo(src, msg)
} else {
return json.Unmarshal(src.Value, spec)
}
. Does it make sense to try and send resources currently marshaled as proto (e.g. mesh) as a JSON? It works for "resources" so maybe? 🤔 If not this then the only other option is to deprecate the current fields and replace them with new ones - which I don't think we should do.

@lukidzi
Copy link
Contributor

lukidzi commented Mar 17, 2025

Triage: @slonka please add more details

@lukidzi lukidzi added triage/needs-information Reviewed and some extra information was asked to the reporter and removed triage/pending This issue will be looked at on the next triage meeting labels Mar 17, 2025
@slonka
Copy link
Contributor Author

slonka commented Mar 18, 2025

We chatted with Ilya and my idea is not going to work. However if we were able to get rid of omitempty on the field and revive #12767 it could work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/needs-information Reviewed and some extra information was asked to the reporter
Projects
None yet
Development

No branches or pull requests

2 participants