Improve behaviour of auto and periodic refresh modes #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
approved these changes
Apr 15, 2019
| @@ -780,10 +780,11 @@ get_input(int prompt_position, struct key *key) | |||
| while (true) { | |||
| int delay = -1; | |||
|
|
|||
| if (opt_refresh_mode == REFRESH_MODE_PERIODIC) { | |||
| if (opt_refresh_mode != REFRESH_MODE_MANUAL) { | |||
There was a problem hiding this comment.
This actually makes sense to me. Initially, the watch feature was lazy to avoid triggering a lot of unnecessary work. Clearly it was too lazy.
src/watch.c
Outdated
| !index_diff(&diff, opt_show_untracked, false)) | ||
| if (event == WATCH_EVENT_SWITCH_VIEW || | ||
| !(check_file_mtime(&handler->last_modified, "%s/index", repo.git_dir) || | ||
| index_diff(&diff, opt_show_untracked, false))) |
There was a problem hiding this comment.
👍 better captures the boolean logic here.
There was a problem hiding this comment.
This part was rewritten to make sure we can detect several successive modification.
This comment has been minimized.
This comment has been minimized.
koutcher
force-pushed
the
gh-794-refresh-mode
branch
11 times, most recently
from
4268489 to
284a914
Compare
jonas
reviewed
May 5, 2019
src/stage.c
Outdated
| @@ -459,8 +461,10 @@ stage_request(struct view *view, enum request request, struct line *line) | |||
|
|
|||
| /* Check whether the staged entry still exists, and close the | |||
| * stage view if it doesn't. */ | |||
| if (view->parent && !stage_exists(view, &stage_status, stage_line_type)) | |||
| if (view->parent && !stage_exists(view, &stage_status, stage_line_type)) { | |||
| stage_line_type = 0; | |||
There was a problem hiding this comment.
Good point to clean up the state before closing
koutcher
force-pushed
the
gh-794-refresh-mode
branch
4 times, most recently
from
fbf9ee8 to
e670064
Compare
koutcher
force-pushed
the
gh-794-refresh-mode
branch
from
b5d05f6 to
0f00a6b
Compare
|
Still looks good to me. |
koutcher
force-pushed
the
gh-794-refresh-mode
branch
6 times, most recently
from
f409533 to
517d46e
Compare
koutcher
force-pushed
the
gh-794-refresh-mode
branch
from
517d46e to
78012db
Compare
koutcher
added a commit
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should improve the current situation or, at least, make all the modes do something. There are still some (pre-existing) problems remaining but none of them is related in the existing issues.
As I don't use the periodic mode personally, I didn't look further but it looks to me that in this mode Tig refreshes unexpectedly 2 or 3 time at startup (hence the claim that it was working sometimes). Not the end of the world but for large repos it can be annoying.
The special handling of the stage view prevents a correct refresh of the status view in some cases.