Endless refresh loop, high CPU usage after refresh or change in refs/main split view

[ghost]

First of all, thanks for a great tool; tig is pretty much the only git client I use since discovering it :)

Since tig version 2.5.0, when a refs/main split view is open and a refresh is triggered, an endless refresh loop (and high CPU usage, at least 50% of a single core on my systems) happens. Depending on the repository and machine, the refreshes may be visible (both views 'flicker' visibly), possibly very often (many times a second). Moving the cursor in this state becomes problematic as well.

To reproduce:

• Start tig with a clean/no user rc (I used TIGRC_USER="" tig here)
• Open a split view of refs and main (either horizontal or vertical will do)
• Do a refresh (e.g. F5)
  • Manual actions that seem to trigger an 'internal refresh' also seem to work (e.g. :exec !git commit or :exec !git commit --amend)
• Tig now starts to refresh constantly, resulting in high CPU usage as well (e.g. in top)
• Get rid of the split view (e.g. q or O) and everything turns back to normal (including CPU usage), even when re-opening the refs/main split.
  • Switching to a different split (e.g. hit Enter on the selected commit to go into a main/diff split) also turns everything back to normal
• Get into the refs/main split again and do a refresh (e.g. F5) or manual action that triggers a refresh and the issue is back.

This happens on all repositories I work on and I can reproduce this on both the tig.git and git.git repositories (the latter only refreshes every few seconds as it seems to wait for the main view to be done populating before doing the next refresh).

As far as I remember the refs/main split is the only split in which I noticed this issue. Some other situations I've explicitly tested:

• It's not an issue when only having either the main or ref views open and performing the same actions that trigger the problem
• It's not an issue with a main/diff split view and performing the same actions that trigger the problem

Version info:

• OS: Ubuntu 18.04.4
• tig --version:

tig version 2.5.0
ncursesw version 6.1.20180127
readline version 8.0

Note: the version of readline that's used is installed via brew (as is tig itself)

[ghost]

Some additional info: on a very small repo (only master and origin/master branches, about 20 commits and about 10 tags) I could not reproduce it. It does seem to refresh a few times max (3-5?) when hitting F5 but then it stops.

[ghost]

Just compiled master locally and can confirm. Thanks for fixing!