bug: doing edit_vsplit from picker enters insert mode with nvim-tree installed

[kristijanhusak]

Did you check docs and existing issues?

• I have read all the snacks.nvim docs
• I have updated the plugin to the latest version before submitting this issue
• I have searched the existing issues of snacks.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.11.0-dev-1574+gac3859a441

Operating system/version

Linux

Describe the bug

I encounter this strange issue in combination with nvim-tree where doing edit_vsplit (or edit_split) enters the insert mode after opening the file. It does not happen until nvim-tree is opened at least once.
I'm not sure if it's their bug or it's here, but I didn't had this issue with Telescope so I'm assuming it's here.

Steps To Reproduce

1. Use the repro provided to open any project
2. Open some file with the <c-p> keymap
3. Find some other file and open it using edit_vsplit, file opens and normal mode is still used
4. Open/close nvim-tree with :NvimTreeToggle
5. Again open some 3rd file with the edit_vsplit, it will automatically go to insert mode after opening file.

At first, I thought it's random, but I also tried this:

1. Open the repro, and immediately toggle nvim-tree. Do not open any file from the tree.
2. Edit some file with edit command, for example :edit README.md
3. Open picker, find a file and open it in vsplit mode, mode goes to insert after opening the file.

Expected Behavior

Expected to stay in normal mode after opening the file.

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "folke/snacks.nvim", opts = {} },
    { "nvim-tree/nvim-tree.lua", opts = {} }
  },
})

vim.keymap.set('n', '<C-p>', function()
  return Snacks.picker.files()
end)

[folke]

I fixed a related issue that probably was the root cause for this as well.
Do let me know if you'd still see the problem

[kristijanhusak]

That fixed it, thanks1

[kristijanhusak]

I noticed one more thing. Opening the picker and then canceling it with Esc (I use ['<Esc>'] = { 'close', mode = { 'n', 'i' } }) doesn't exit insert mode.

[folke]

I would be very surprised about this, since I do a stopinsert and also can't reproduce.

[kristijanhusak]

It happened in conjuction with nvim-tree as reported, but now I cannot reproduce it. I'll keep an eye on it, thanks!

[asilvadesigns]

I'm experiencing the same issue with nvim-tree installed, it occurs in the following way.

If nvim-tree buffer has not been opened,
then opening the snacks picker, typing some result, and exiting the snacks picker.
neovim returns to normal mode as expected.

If nvim-tree buffer has been opened,
then opening the snacks picker, typing some result, and exiting the snacks picker.
neovim remains in insert mode.

gonna keep messing around with this...

[folke]

Can you update and try again?
I've remove the usage of the promp buffer callbacks. They behave quite weird.

[kristijanhusak]

It still happens, but only when I map <Esc> to close.
Here's the repro:

vim.env.LAZY_STDPATH = '.repro'
load(vim.fn.system('curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua'))()

require('lazy.minit').repro({
  spec = {
    {
      'folke/snacks.nvim',
      opts = {
        picker = {
          win = {
            input = {
              keys = {
                ['<Esc>'] = { 'close', mode = { 'n', 'i' } },
              },
            },
          },
        },
      },
    },
    { 'nvim-tree/nvim-tree.lua', opts = {} },
  },
})

vim.keymap.set('n', '<C-p>', function()
  return Snacks.picker.files()
end)
vim.keymap.set('n', '<C-n>', function()
  vim.cmd('NvimTreeToggle')
end)

Steps to reproduce:

1. Start with repro, open picker with C-p, close with Esc, everything works fine
2. Open/close nvim tree by pressing C-n twice
3. Open picker with c-p again, close with Esc, stays in insert mode

Here's the video:

insert-mode.mp4

[asilvadesigns]

Yup, same issue for me when using Esc as shown above

[folke]

I just changed it to always stopinsert, even when the picker is already closed.
nvim-tree must be interfering with startinsert somehow.

[asilvadesigns]

that did it!, thank you, really odd