feat(layout): configurable winhighlight options for layout's box_wins #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix that stylua issue |
folke
pushed a commit
that referenced
this pull request
Feb 25, 2025
🤖 I have created a release *beep* *boop* --- ## [2.22.0](v2.21.0...v2.22.0) (2025-02-25) ### Features * **image:** allow disabling math rendering. Closes [#1247](#1247) ([1543a06](1543a06)) * **image:** configurable templates for math expressions. Closes [#1338](#1338) ([e039139](e039139)) * **image:** removed `org` integration, since that is now handled by the org mode plugin directly. ([956fe69](956fe69)) * **picker.input:** added some ctrl+r keymaps similar to cmdline. Closes [#1420](#1420) ([c864a7d](c864a7d)) * **util:** util method to check if ts lang is available on any Neovim version. See [#1422](#1422) ([e2cb9df](e2cb9df)) ### Bug Fixes * **compat:** fixup ([ceabfc1](ceabfc1)) * **compat:** properly detect async treesitter parsing ([842605f](842605f)) * **compat:** vim.fs.normalize. Closes [#1321](#1321) ([2295cfc](2295cfc)) * **dim:** check that win is valid when animating dim. Closes [#1342](#1342) ([47e1440](47e1440)) * **image.placement:** max width/height in cells is 297. Closes [#1345](#1345) ([5fa93cb](5fa93cb)) * **image.terminal:** reset queue when timer runs ([2b34c4d](2b34c4d)) * **image.terminal:** write queued terminal output on main ([1b63b18](1b63b18)) * **picker.buffers:** add `a` flag when buffer is visible in a window. See [#1417](#1417) ([91c3da0](91c3da0)) * **picker.recent:** expand to full path before normalizing. Closes [#1406](#1406) ([cf47fa7](cf47fa7)) * **picker:** allow overriding winhl of layout box wins. Closes [#1424](#1424) ([b0f983e](b0f983e)) * **picker:** disable regex for grep_word ([#1363](#1363)) ([54298eb](54298eb)) * **picker:** remove unused keymaps for mouse scrolling ([33df54d](33df54d)) * **picker:** update titles before showing. Closes [#1337](#1337) ([3ae9863](3ae9863)) * **scope:** use `rawequal` to check if scope impl is treesitter. Closes [#1413](#1413) ([4ce197b](4ce197b)) * **scroll:** compat with Neovim 0.9.4 ([4c52b7f](4c52b7f)) * **statuscolumn:** right-align the current line number when relativenumber=true. Closes [#1376](#1376) ([dd15e3a](dd15e3a)) * **win:** don't update title is relative win is invalid. Closes [#1348](#1348) ([a00c323](a00c323)) * **win:** use correct keys for displaying help. Closes [#1364](#1364) ([b100c93](b100c93)) * **zen:** always count cmdheight towards Zen bottom offset ([#1402](#1402)) ([041bf1d](041bf1d)) ### Performance Improvements * **scope:** use async treesitter parsing when available ([e0f882e](e0f882e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now，the layout's config such as:
{ layout = { backdrop = false, relative = "cursor", width = 0.5, min_width = 80, height = 0.4, min_height = 3, box = "vertical", border = "rounded", title = "{title}", title_pos = "center", wo = { winhighlight = "FloatBorder:LspWinCodeActionBorder,FloatTitle:LspWinCodeActionTitle", }, { win = "input", height = 1, border = "bottom", wo = { winhighlight = "FloatBorder:LspWinCodeActionBorder" } }, { win = "list", border = "none" }, { win = "preview", title = "{preview}", height = 0.4, border = "top" }, }, }the
layout.wo.winhighlightdoes not work for box wins.This merge make the config above work.
Related Issue(s)
Screenshots