Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: deduplicaton in smart search not working? #1406

Closed
4 tasks done
vekexasia opened this issue Feb 24, 2025 · 3 comments · Fixed by #1335
Closed
4 tasks done

bug: deduplicaton in smart search not working? #1406

vekexasia opened this issue Feb 24, 2025 · 3 comments · Fixed by #1335
Labels
bug Something isn't working

Comments

@vekexasia
Copy link

Did you check docs and existing issues?

  • I have read all the snacks.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of snacks.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.11.0-dev

Operating system/version

WSL ubuntu

Describe the bug

when using the smart picker i get result both from buffer and file but it looks like they should be deduplicated. See picture.

Image

Steps To Reproduce

  1. Open a buffer
  2. use the smart search

Expected Behavior

If i understand properly search res should deduplicated by file identifier

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "folke/snacks.nvim", opts = {} },
    -- add any other plugins here
  },
})
@vekexasia vekexasia added the bug Something isn't working label Feb 24, 2025
@folke
Copy link
Owner

folke commented Feb 25, 2025

That second result is wrong. Can you go to that result and then press <a-d> and paste the result here?

@vekexasia
Copy link
Author

hey @folke, fyi on my dayjob machine i cannot replicate, i will retry when back home

@folke folke closed this as completed in cf47fa7 Feb 25, 2025
@folke
Copy link
Owner

folke commented Feb 25, 2025

if you'd still see this after updating, let me know the output of <a-d>

folke pushed a commit that referenced this issue Feb 25, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.22.0](v2.21.0...v2.22.0)
(2025-02-25)


### Features

* **image:** allow disabling math rendering. Closes
[#1247](#1247)
([1543a06](1543a06))
* **image:** configurable templates for math expressions. Closes
[#1338](#1338)
([e039139](e039139))
* **image:** removed `org` integration, since that is now handled by the
org mode plugin directly.
([956fe69](956fe69))
* **picker.input:** added some ctrl+r keymaps similar to cmdline. Closes
[#1420](#1420)
([c864a7d](c864a7d))
* **util:** util method to check if ts lang is available on any Neovim
version. See [#1422](#1422)
([e2cb9df](e2cb9df))


### Bug Fixes

* **compat:** fixup
([ceabfc1](ceabfc1))
* **compat:** properly detect async treesitter parsing
([842605f](842605f))
* **compat:** vim.fs.normalize. Closes
[#1321](#1321)
([2295cfc](2295cfc))
* **dim:** check that win is valid when animating dim. Closes
[#1342](#1342)
([47e1440](47e1440))
* **image.placement:** max width/height in cells is 297. Closes
[#1345](#1345)
([5fa93cb](5fa93cb))
* **image.terminal:** reset queue when timer runs
([2b34c4d](2b34c4d))
* **image.terminal:** write queued terminal output on main
([1b63b18](1b63b18))
* **picker.buffers:** add `a` flag when buffer is visible in a window.
See [#1417](#1417)
([91c3da0](91c3da0))
* **picker.recent:** expand to full path before normalizing. Closes
[#1406](#1406)
([cf47fa7](cf47fa7))
* **picker:** allow overriding winhl of layout box wins. Closes
[#1424](#1424)
([b0f983e](b0f983e))
* **picker:** disable regex for grep_word
([#1363](#1363))
([54298eb](54298eb))
* **picker:** remove unused keymaps for mouse scrolling
([33df54d](33df54d))
* **picker:** update titles before showing. Closes
[#1337](#1337)
([3ae9863](3ae9863))
* **scope:** use `rawequal` to check if scope impl is treesitter. Closes
[#1413](#1413)
([4ce197b](4ce197b))
* **scroll:** compat with Neovim 0.9.4
([4c52b7f](4c52b7f))
* **statuscolumn:** right-align the current line number when
relativenumber=true. Closes
[#1376](#1376)
([dd15e3a](dd15e3a))
* **win:** don't update title is relative win is invalid. Closes
[#1348](#1348)
([a00c323](a00c323))
* **win:** use correct keys for displaying help. Closes
[#1364](#1364)
([b100c93](b100c93))
* **zen:** always count cmdheight towards Zen bottom offset
([#1402](#1402))
([041bf1d](041bf1d))


### Performance Improvements

* **scope:** use async treesitter parsing when available
([e0f882e](e0f882e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants