Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: bad argument #1 to 'tonumber' #1345

Closed
4 tasks done
nduartech opened this issue Feb 20, 2025 · 4 comments · Fixed by #1335
Closed
4 tasks done

bug: bad argument #1 to 'tonumber' #1345

nduartech opened this issue Feb 20, 2025 · 4 comments · Fixed by #1335
Labels
bug Something isn't working

Comments

@nduartech
Copy link

nduartech commented Feb 20, 2025

Did you check docs and existing issues?

  • I have read all the snacks.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of snacks.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.11.0-dev-1785+gb0bbe25c48

Operating system/version

EndeavourOS

Describe the bug

Error executing vim.schedule lua callback: ...are/nvim/lazy/snacks.nvim/lua/snacks/image/placement.lua:24: bad argument #1 to 'tonumber' (string expected, got nil)
stack traceback:
        [C]: in function 'tonumber'
        ...are/nvim/lazy/snacks.nvim/lua/snacks/image/placement.lua:24: in function '__index'
        ...are/nvim/lazy/snacks.nvim/lua/snacks/image/placement.lua:196: in function 'render_grid'
        ...are/nvim/lazy/snacks.nvim/lua/snacks/image/placement.lua:353: in function 'update'
        ...are/nvim/lazy/snacks.nvim/lua/snacks/image/placement.lua:92: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Steps To Reproduce

Open image from recent files picker or other picker, image fails to load, error is as above

Expected Behavior

Image should load no error?

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

  Loaded (12)
    ● flash.nvim 0.44ms  VeryLazygrapple.nvim 0.12ms 󰢱 lualine.components.grapplelualine.nvimlazy.nvim 5.06ms  init.lualualine.nvim 0.06ms 󰢱 lualinecore.plugin-confignoice.nvim 0.35ms  VeryLazynui.nvim 0.07ms  noice.nvimnvim-treesitter 2.65ms  startnvim-web-devicons 0.09ms  oil.nvimoil.nvim 0.87ms 󰢱 oilcore.plugin-configsnacks.nvim 0.89ms  starttokyonight.nvim 2.2ms  startwhich-key.nvim 1.13ms  VeryLazy

  Not Loaded (21)
    ○ actions-preview.nvimLspAttachblink-ripgrep.nvimblink.cmpblink.cmpInsertEnterCmdlineEnterComment.nvimBufReadPreBufNewFilefriendly-snippetsblink.cmpgitsigns.nvimBufReadPreBufNewFileinc-rename.nvimIncRenameLspAttachlazydev.nvimluaLspAttachlsplinks.nvimgxnvim-autopairsInsertEnternvim-colorizer.luaBufReadPreBufNewFilenvim-rip-substituteRipSubstituteBufReadPreBufNewFilenvim-ts-autotagBufReadPreBufNewFileoutline.nvimOutlinepersistence.nvimBufReadPreBufNewFileprecognition.nvimBufReadPreBufNewFilerainbow-delimiters.nvimBufReadPreBufNewFilerustaceanvimrusttiny-inline-diagnostic.nvimBufReadPrevim-illuminate[[]] BufReadPostBufNewFileyuck.vimBufReadPre
@nduartech nduartech added the bug Something isn't working label Feb 20, 2025
@nduartech
Copy link
Author

nduartech commented Feb 20, 2025

My bad if this is just something I'm doing wrong, but I waited a few updates to do this to see if it would just go away. The image does appear if I do :messages weirdly enough

@folke
Copy link
Owner

folke commented Feb 20, 2025

Can you make your terminal window smaller and see if that fixes it?

@folke folke closed this as completed in 5fa93cb Feb 20, 2025
@folke
Copy link
Owner

folke commented Feb 20, 2025

Should be fixed now.

@nduartech
Copy link
Author

Just seeing this now, can confirm it is fixed. 🙏🏽🙏🏽🙏🏽 Absolute 🐐

folke pushed a commit that referenced this issue Feb 25, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.22.0](v2.21.0...v2.22.0)
(2025-02-25)


### Features

* **image:** allow disabling math rendering. Closes
[#1247](#1247)
([1543a06](1543a06))
* **image:** configurable templates for math expressions. Closes
[#1338](#1338)
([e039139](e039139))
* **image:** removed `org` integration, since that is now handled by the
org mode plugin directly.
([956fe69](956fe69))
* **picker.input:** added some ctrl+r keymaps similar to cmdline. Closes
[#1420](#1420)
([c864a7d](c864a7d))
* **util:** util method to check if ts lang is available on any Neovim
version. See [#1422](#1422)
([e2cb9df](e2cb9df))


### Bug Fixes

* **compat:** fixup
([ceabfc1](ceabfc1))
* **compat:** properly detect async treesitter parsing
([842605f](842605f))
* **compat:** vim.fs.normalize. Closes
[#1321](#1321)
([2295cfc](2295cfc))
* **dim:** check that win is valid when animating dim. Closes
[#1342](#1342)
([47e1440](47e1440))
* **image.placement:** max width/height in cells is 297. Closes
[#1345](#1345)
([5fa93cb](5fa93cb))
* **image.terminal:** reset queue when timer runs
([2b34c4d](2b34c4d))
* **image.terminal:** write queued terminal output on main
([1b63b18](1b63b18))
* **picker.buffers:** add `a` flag when buffer is visible in a window.
See [#1417](#1417)
([91c3da0](91c3da0))
* **picker.recent:** expand to full path before normalizing. Closes
[#1406](#1406)
([cf47fa7](cf47fa7))
* **picker:** allow overriding winhl of layout box wins. Closes
[#1424](#1424)
([b0f983e](b0f983e))
* **picker:** disable regex for grep_word
([#1363](#1363))
([54298eb](54298eb))
* **picker:** remove unused keymaps for mouse scrolling
([33df54d](33df54d))
* **picker:** update titles before showing. Closes
[#1337](#1337)
([3ae9863](3ae9863))
* **scope:** use `rawequal` to check if scope impl is treesitter. Closes
[#1413](#1413)
([4ce197b](4ce197b))
* **scroll:** compat with Neovim 0.9.4
([4c52b7f](4c52b7f))
* **statuscolumn:** right-align the current line number when
relativenumber=true. Closes
[#1376](#1376)
([dd15e3a](dd15e3a))
* **win:** don't update title is relative win is invalid. Closes
[#1348](#1348)
([a00c323](a00c323))
* **win:** use correct keys for displaying help. Closes
[#1364](#1364)
([b100c93](b100c93))
* **zen:** always count cmdheight towards Zen bottom offset
([#1402](#1402))
([041bf1d](041bf1d))


### Performance Improvements

* **scope:** use async treesitter parsing when available
([e0f882e](e0f882e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants