Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
365 FCS system #366
365 FCS system #366
Changes from all commits
f65618a
9233c6f
d8042e5
f991f78
31d2d43
cbdfc77
93aac8b
7802760
acf4336
34f50ba
c1e31cb
392fe49
188251c
7b7b5cc
38dd4c4
e56f315
c5782df
37056d9
221c7e6
cc0ff01
2e1cfca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a direct hit (
isDirect == true
), will it always be the first element in_this
? Otherwise, shouldn't this loop through each of the parts hit (the sub-arrays of_this
) to check if any are direct hits?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm checking on this to be sure, but in testing the observed trigger rate seems to be appropriate for the initial impact being first, or at least a direct hit being first enough of the time to be in the right ballpark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. If it seems to be having the desired effect then no issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
setWeaponZeroing
Global-Argument,Global-Effect?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wiki helpfully does not say. I think I remember testing it and having it work as expected on remote units, but I'll have to check again to prove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw the wiki didn't say which is why I asked. If you've tested previously it's probably fine