-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
365 FCS system #366
365 FCS system #366
Conversation
|
||
// Hit EH for FCS failure | ||
_vehicle addEventHandler ["HitPart",{ | ||
(_this select 0) params ["_target", "_shooter", "_projectile", "_position", "_velocity", "_selection", "_ammo", "_vector", "_radius", "_surfaceType", "_isDirect"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a direct hit (isDirect == true
), will it always be the first element in _this
? Otherwise, shouldn't this loop through each of the parts hit (the sub-arrays of _this
) to check if any are direct hits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm checking on this to be sure, but in testing the observed trigger rate seems to be appropriate for the initial impact being first, or at least a direct hit being first enough of the time to be in the right ballpark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. If it seems to be having the desired effect then no issue
if !(_x == "this") then { | ||
_targetMuzzle = _x; | ||
}; | ||
_zeroCheck = _currentGunner setWeaponZeroing [_targetWeapon,_targetMuzzle,1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is setWeaponZeroing
Global-Argument,Global-Effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wiki helpfully does not say. I think I remember testing it and having it work as expected on remote units, but I'll have to check again to prove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw the wiki didn't say which is why I asked. If you've tested previously it's probably fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Commander's override now lasts 4 seconds at maximum to prevent automated pixelhunting from locking out the gunner.
The FCS system can now be flagged to only add the driver's brake override action and skip the rest.
Made a couple of small improvements since we're still waiting for other stuff for release. OK finished now |
Co-authored-by: Euan Hunter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Two small typos suggestion fixes, and a possible best practise thing. Looking forward to having this in 3.5.7 and, by proxy, more missions
Co-authored-by: Euan Hunter <[email protected]>
Co-authored-by: Euan Hunter <[email protected]>
Was conflicted with the radio branch. That's resolved, just needs reapproval |
Per #365 adds the better FCS simulation module.