Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiler option for ignoring specific symbols #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/compiler.sk
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace GLSLX {
var removeWhitespace = true
var renameSymbols = RenameSymbols.ALL
var trimSymbols = true
var ignoredSymbols List<string> = []
var fileAccess fn(string, string) Source = null
}

Expand Down
8 changes: 6 additions & 2 deletions src/core/renamer.sk
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace GLSLX.Renamer {
def rename(globals List<Node>, options CompilerOptions) StringMap<string> {
return Renamer.new(options.renameSymbols)._rename(globals)
return Renamer.new(options.renameSymbols, options.ignoredSymbols)._rename(globals)
}

class SymbolInfo {
Expand Down Expand Up @@ -28,6 +28,7 @@ namespace GLSLX.Renamer {

class GLSLX.Renamer {
var _renameSymbols RenameSymbols
var _ignoredSymbols List<string>
var _functionList List<SymbolInfo> = []
var _symbolInfoList List<SymbolInfo> = []
var _symbolInfoMap IntMap<SymbolInfo> = {}
Expand Down Expand Up @@ -55,6 +56,9 @@ class GLSLX.Renamer {
var name string = null
for info in group {
for symbol in info.symbols.values {
if symbol.name in _ignoredSymbols {
continue
}
var old = symbol.name
if !symbol.isImportedOrExported && (_renameSymbols == .ALL || _renameSymbols == .INTERNAL_ONLY && !symbol.isAttributeOrUniform) {
if name == null {
Expand Down Expand Up @@ -136,7 +140,7 @@ class GLSLX.Renamer {
while true {
var name = _numberToName(_nextSymbolName)
_nextSymbolName++
if name in Tokenizer.keywords || name in Tokenizer.reservedWords || name.startsWith("gl_") {
if name in Tokenizer.keywords || name in Tokenizer.reservedWords || name.startsWith("gl_") || name in _ignoredSymbols {
continue
}
return name
Expand Down
8 changes: 8 additions & 0 deletions src/exports/exports.sk
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ Advanced:
--renaming=MODE
Valid modes are all, internal-only, or none. Defaults to all.

--ignored-symbols=SYMBOLS
A list of symbols to be ignored during renaming. Formatted as a JSON array. Defaults to an empty array.

--keep-symbols
Don't inline constants or remove unused symbols.
")
Expand Down Expand Up @@ -166,6 +169,7 @@ Advanced:
if args.disableRewriting { options.compactSyntaxTree = false }
if args.prettyPrint { options.removeWhitespace = false }
if args.keepSymbols { options.trimSymbols = false }
if args.ignoredSymbols { options.ignoredSymbols = args.ignoredSymbols }
if args.fileAccess { options.fileAccess = wrapFileAccess(args.fileAccess) }

var result = Compiler.compile(log, sources, options)
Expand Down Expand Up @@ -515,6 +519,10 @@ Advanced:
options.renameSymbols = renameSymbols[text]
}

else if arg.startsWith("--ignored-symbols=") {
options.ignoredSymbols = dynamic.JSON.parse(arg.slice("--ignored-symbols=".count))
}

else {
console.log("invalid flag \"\(arg)\"")
process.exit(1)
Expand Down
7 changes: 7 additions & 0 deletions src/test/driver.sk
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ namespace GLSLX.Tests {
_options.removeWhitespace = false
_options.renameSymbols = .NONE
_options.trimSymbols = false
_options.ignoredSymbols = []
return self
}

Expand All @@ -57,6 +58,11 @@ namespace GLSLX.Tests {
return self
}

def ignoredSymbols(ignoredSymbols List<string>) CompilerTest {
_options.ignoredSymbols = ignoredSymbols
return self
}

def fileAccess(callback fn(string, string) Source) CompilerTest {
_options.fileAccess = callback
return self
Expand Down Expand Up @@ -172,6 +178,7 @@ namespace GLSLX.Tests {
testMinifier
testParser
testResolver
testRenamer
testRewriter
testTooltips
testFormatter
Expand Down
80 changes: 80 additions & 0 deletions src/test/renamer.tests.sk
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
namespace GLSLX.Tests {
def testRenamer {
test("
uniform sampler2D texture;
uniform vec4 color;
attribute vec2 position;
varying vec2 coord;

export void vertex() {
coord = position;
gl_Position = vec4(position*2.0 - 1.0, 0.0,1.0);
}

export void colorFragment() {
gl_FragColor = color;
}

export void textureFragment() {
gl_FragColor = texture2D(texture, coord);
}
", "
[vertex]
uniform sampler2D f;
uniform vec4 g;
attribute vec2 position;
varying vec2 e;

void main() {
e = position;
gl_Position = vec4(position * 2.0 - 1.0, 0.0, 1.0);
}

void h() {
gl_FragColor = g;
}

void i() {
gl_FragColor = texture2D(f, e);
}

[colorFragment]
uniform sampler2D f;
uniform vec4 g;
attribute vec2 position;
varying vec2 e;

void vertex() {
e = position;
gl_Position = vec4(position * 2.0 - 1.0, 0.0, 1.0);
}

void main() {
gl_FragColor = g;
}

void i() {
gl_FragColor = texture2D(f, e);
}

[textureFragment]
uniform sampler2D f;
uniform vec4 g;
attribute vec2 position;
varying vec2 e;

void vertex() {
e = position;
gl_Position = vec4(position * 2.0 - 1.0, 0.0, 1.0);
}

void h() {
gl_FragColor = g;
}

void main() {
gl_FragColor = texture2D(f, e);
}
").ignoredSymbols(["position", "vertex"]).renameAll
}
}