Add compiler option for ignoring specific symbols #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new line Fix parsing of `--ignored-symbols` argument
uki-dev
force-pushed
the
ignore-symbols
branch
from
71b3b78 to
a811658
Compare
|
@evanw pinging as unable to assign you as a reviewer. |
|
@evanw any chance to get your eyes on this and some feedback on how to improve/change to get this merged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is essential to have the ability to preserve certain symbols from renaming when pairing GLSLX with external frameworks in which specific symbols are static.
This is addressed by adding an additional variable
ignoredSymbols List<string>toCompilerOptionswhich is checked against when renaming symbols & generating new symbol names.Ignored symbols can be passed via the command line using the
--ignored-symbolsargument which accepts a JSON formatted array for example;--ignored-symbols='["foo", "bar"]'