Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] 🌊 Streams: Overview page redesign (#214196) #215471

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

flash1293
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

This PR overhauls the overview page.

Classic stream:
<img width="1004" alt="Screenshot 2025-03-12 at 21 00 39"
src="https://github.com/user-attachments/assets/a058da08-0ae2-48cc-abca-359b23288b32"
/>

Wired stream:
<img width="1019" alt="Screenshot 2025-03-12 at 21 01 56"
src="https://github.com/user-attachments/assets/bca04537-f79b-4814-8e31-9d3dae18ad90"
/>

## Doubts / things I changed from the design

* Quick links is just all dashboards, so I adjusted the wording
accordingly. Also, since we render all dashboards, there isn't really
value in "View all assets"
* The panel on top is already stating the count of docs, why should we
repeat that in the histogram panel?
* No search bar - in the beginning we said we don't want this page to
become discover, a search bar feels like we are going there. Also, what
should the user enter there? I don't think we want to buy deeper in KQL
* Should the count of docs be the total count of the count for the
currently selected time range? Not sure what makes more sense
* For wired streams I left the tabs in place to switch between child
streams and quick links. We can revisit this once we get closer to
actually releasing wired streams

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 184d0a3)

# Conflicts:
#	x-pack/platform/plugins/shared/streams_app/tsconfig.json
@flash1293 flash1293 merged commit 8c9eccb into elastic:8.x Mar 21, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 605 606 +1
apm 1926 1927 +1
charts 129 130 +1
cloudSecurityPosture 671 672 +1
dashboard 666 667 +1
dataVisualizer 756 757 +1
discover 1248 1249 +1
esql 208 209 +1
esqlDataGrid 412 413 +1
eventAnnotationListing 563 564 +1
expressionHeatmap 162 163 +1
expressionMetricVis 102 103 +1
expressionPartitionVis 173 174 +1
expressionTagcloud 150 151 +1
expressionXY 230 231 +1
graph 287 288 +1
investigateApp 574 575 +1
lens 1498 1499 +1
logsExplorer 455 456 +1
ml 2433 2434 +1
observability 1252 1253 +1
observabilityAIAssistantApp 421 422 +1
securitySolution 7143 7144 +1
slo 1124 1125 +1
streamsApp 387 400 +13
transform 716 717 +1
triggersActionsUi 834 835 +1
visDefaultEditor 199 200 +1
visTypeTimelion 59 60 +1
visTypeTimeseries 458 459 +1
total +42

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/visualization-utils 22 25 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 373.3KB 377.3KB +4.1KB
unifiedHistogram 63.2KB 63.2KB +6.0B
total +4.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 395.1KB 395.3KB +221.0B
Unknown metric groups

API count

id before after diff
@kbn/visualization-utils 24 27 +3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants