🌊 Streams: Overview page redesign #214196
Conversation
flash1293
added
release_note:skip
|
/ci |
|
/ci |
sounds good, hopefully we'll have more in the future
makes sense, we don't have good use for it anyways
I think time range makes more sense, that's what we do in most other places across Kibana
👍 |
|
Discussed offline:
|
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Maybe not a KQL bar but what about a UI search like |
I think we can do that, but then it still shouldn't be at the very top of the page, but in the child streams panel |
|
@flash1293 The refresh button does not seem to trigger any updates on the overview page (graph or metadata) unless I change the period. I see a few network requests triggered but the view is not refreshed |
| [share.url.locators] | ||
| ); | ||
|
|
||
| const bucketSize = useMemo(() => computeInterval(timeRange, data), [data, timeRange]); |
There was a problem hiding this comment.
Lifecycle graph uses the data-plugin logic to calculate interval.
Not sure how much it differs from this one but it would be nice to align
There was a problem hiding this comment.
The computeInterval is what's used by the ESQL histogram AFAICT, seems like a good standard. The one from the data plugin seems like it's used for the KQL discover bar and is more configurable, I don't think we need to lean into these here.
So if anything I would vote for using computeInterval everywhere.
|
@klacabane good catch with the refresh button - the problem was that the time range never changed (it's always |
I think still a valuable addition |
...hared/streams_app/public/components/stream_detail_overview/components/stream_stats_panel.tsx
Outdated
Show resolved
Hide resolved
.../plugins/shared/streams_app/public/components/stream_detail_overview/utils/format_helpers.ts
Outdated
Show resolved
Hide resolved
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/13978074845 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This PR overhauls the overview page. Classic stream: <img width="1004" alt="Screenshot 2025-03-12 at 21 00 39" src="https://github.com/user-attachments/assets/a058da08-0ae2-48cc-abca-359b23288b32" /> Wired stream: <img width="1019" alt="Screenshot 2025-03-12 at 21 01 56" src="https://github.com/user-attachments/assets/bca04537-f79b-4814-8e31-9d3dae18ad90" /> ## Doubts / things I changed from the design * Quick links is just all dashboards, so I adjusted the wording accordingly. Also, since we render all dashboards, there isn't really value in "View all assets" * The panel on top is already stating the count of docs, why should we repeat that in the histogram panel? * No search bar - in the beginning we said we don't want this page to become discover, a search bar feels like we are going there. Also, what should the user enter there? I don't think we want to buy deeper in KQL * Should the count of docs be the total count of the count for the currently selected time range? Not sure what makes more sense * For wired streams I left the tabs in place to switch between child streams and quick links. We can revisit this once we get closer to actually releasing wired streams --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 184d0a3) # Conflicts: # x-pack/platform/plugins/shared/streams_app/tsconfig.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [🌊 Streams: Overview page redesign (#214196)](#214196) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-20T19:48:10Z","message":"🌊 Streams: Overview page redesign (#214196)\n\nThis PR overhauls the overview page.\n\nClassic stream:\n<img width=\"1004\" alt=\"Screenshot 2025-03-12 at 21 00 39\"\nsrc=\"https://github.com/user-attachments/assets/a058da08-0ae2-48cc-abca-359b23288b32\"\n/>\n\nWired stream:\n<img width=\"1019\" alt=\"Screenshot 2025-03-12 at 21 01 56\"\nsrc=\"https://github.com/user-attachments/assets/bca04537-f79b-4814-8e31-9d3dae18ad90\"\n/>\n\n\n## Doubts / things I changed from the design\n\n* Quick links is just all dashboards, so I adjusted the wording\naccordingly. Also, since we render all dashboards, there isn't really\nvalue in \"View all assets\"\n* The panel on top is already stating the count of docs, why should we\nrepeat that in the histogram panel?\n* No search bar - in the beginning we said we don't want this page to\nbecome discover, a search bar feels like we are going there. Also, what\nshould the user enter there? I don't think we want to buy deeper in KQL\n* Should the count of docs be the total count of the count for the\ncurrently selected time range? Not sure what makes more sense\n* For wired streams I left the tabs in place to switch between child\nstreams and quick links. We can revisit this once we get closer to\nactually releasing wired streams\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"184d0a32adb2ec372c6427903d9269f813f04b6d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-logs","backport:version","Feature:Streams","v9.1.0","v8.19.0"],"title":"🌊 Streams: Overview page redesign","number":214196,"url":"https://github.com/elastic/kibana/pull/214196","mergeCommit":{"message":"🌊 Streams: Overview page redesign (#214196)\n\nThis PR overhauls the overview page.\n\nClassic stream:\n<img width=\"1004\" alt=\"Screenshot 2025-03-12 at 21 00 39\"\nsrc=\"https://github.com/user-attachments/assets/a058da08-0ae2-48cc-abca-359b23288b32\"\n/>\n\nWired stream:\n<img width=\"1019\" alt=\"Screenshot 2025-03-12 at 21 01 56\"\nsrc=\"https://github.com/user-attachments/assets/bca04537-f79b-4814-8e31-9d3dae18ad90\"\n/>\n\n\n## Doubts / things I changed from the design\n\n* Quick links is just all dashboards, so I adjusted the wording\naccordingly. Also, since we render all dashboards, there isn't really\nvalue in \"View all assets\"\n* The panel on top is already stating the count of docs, why should we\nrepeat that in the histogram panel?\n* No search bar - in the beginning we said we don't want this page to\nbecome discover, a search bar feels like we are going there. Also, what\nshould the user enter there? I don't think we want to buy deeper in KQL\n* Should the count of docs be the total count of the count for the\ncurrently selected time range? Not sure what makes more sense\n* For wired streams I left the tabs in place to switch between child\nstreams and quick links. We can revisit this once we get closer to\nactually releasing wired streams\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"184d0a32adb2ec372c6427903d9269f813f04b6d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214196","number":214196,"mergeCommit":{"message":"🌊 Streams: Overview page redesign (#214196)\n\nThis PR overhauls the overview page.\n\nClassic stream:\n<img width=\"1004\" alt=\"Screenshot 2025-03-12 at 21 00 39\"\nsrc=\"https://github.com/user-attachments/assets/a058da08-0ae2-48cc-abca-359b23288b32\"\n/>\n\nWired stream:\n<img width=\"1019\" alt=\"Screenshot 2025-03-12 at 21 01 56\"\nsrc=\"https://github.com/user-attachments/assets/bca04537-f79b-4814-8e31-9d3dae18ad90\"\n/>\n\n\n## Doubts / things I changed from the design\n\n* Quick links is just all dashboards, so I adjusted the wording\naccordingly. Also, since we render all dashboards, there isn't really\nvalue in \"View all assets\"\n* The panel on top is already stating the count of docs, why should we\nrepeat that in the histogram panel?\n* No search bar - in the beginning we said we don't want this page to\nbecome discover, a search bar feels like we are going there. Also, what\nshould the user enter there? I don't think we want to buy deeper in KQL\n* Should the count of docs be the total count of the count for the\ncurrently selected time range? Not sure what makes more sense\n* For wired streams I left the tabs in place to switch between child\nstreams and quick links. We can revisit this once we get closer to\nactually releasing wired streams\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"184d0a32adb2ec372c6427903d9269f813f04b6d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
This PR overhauls the overview page. Classic stream: <img width="1004" alt="Screenshot 2025-03-12 at 21 00 39" src="https://github.com/user-attachments/assets/a058da08-0ae2-48cc-abca-359b23288b32" /> Wired stream: <img width="1019" alt="Screenshot 2025-03-12 at 21 01 56" src="https://github.com/user-attachments/assets/bca04537-f79b-4814-8e31-9d3dae18ad90" /> ## Doubts / things I changed from the design * Quick links is just all dashboards, so I adjusted the wording accordingly. Also, since we render all dashboards, there isn't really value in "View all assets" * The panel on top is already stating the count of docs, why should we repeat that in the histogram panel? * No search bar - in the beginning we said we don't want this page to become discover, a search bar feels like we are going there. Also, what should the user enter there? I don't think we want to buy deeper in KQL * Should the count of docs be the total count of the count for the currently selected time range? Not sure what makes more sense * For wired streams I left the tabs in place to switch between child streams and quick links. We can revisit this once we get closer to actually releasing wired streams --------- Co-authored-by: kibanamachine <[email protected]>
This PR overhauls the overview page.
Classic stream:
Wired stream:
Doubts / things I changed from the design