[release/6.0.4xx] [msbuild] Copy partial app manifests to build server if they exists on Windows. Fixes #15267. #15467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Windows. Fixes dotnet#15267. The exclusion of partial app manifests happened here, but the commit doesn't explain why: dotnet@f4a4b23#diff-178de6110858688b9f7c2e8e57a873f5ac9498b355a456bfc18547ab2df876bc It's certainly wrong if the partial app manifest is a part of the project, but this exclusion might be because partial app manifests might be added as a part of the build as well. So change the logic to copy partial app manifests from Windows if they exist there. Fixes dotnet#15267.
vs-mobiletools-engineering-service2
requested review from
emaf,
mauroa,
rolfbjarne and
chamons
as code owners
vs-mobiletools-engineering-service2
added
backported
bug
📋 [PR Build] API Diff 📋API Current PR diff✅ API Diff (from PR only) (no change) View dotnet API diffView dotnet legacy API diffAPI diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1106.Monterey' |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
rolfbjarne
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exclusion of partial app manifests happened here, but the commit doesn't explain why:
f4a4b23#diff-178de6110858688b9f7c2e8e57a873f5ac9498b355a456bfc18547ab2df876bc
It's certainly wrong if the partial app manifest is a part of the project, but
this exclusion might be because partial app manifests might be added as a part
of the build as well.
So change the logic to copy partial app manifests from Windows if they exist
there.
Fixes #15267.
Backport of #15328