[msbuild] Copy partial app manifests to build server if they exists on Windows. Fixes #15267. #15328
Conversation
…n Windows. Fixes dotnet#15267. The exclusion of partial app manifests happened here, but the commit doesn't explain why: dotnet@f4a4b23#diff-178de6110858688b9f7c2e8e57a873f5ac9498b355a456bfc18547ab2df876bc It's certainly wrong if the partial app manifest is a part of the project, but this exclusion might be because partial app manifests might be added as a part of the build as well. So change the logic to copy partial app manifests from Windows if they exist there. Fixes dotnet#15267.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2558). |
|
@rolfbjarne I think the intention was to exclude the partial app manifest generated by some other task. The problem is that file in Windows is empty, so we were replacing the real one in the Mac by the empty one from Windows. The code you changed will be executed on Windows, and items that go through that code will exist there. The problem is it won't discriminate between empty and non-empty partial app manifests. I think we should check if it's an empty file instead of if it exists. |
|
@emaf ok, changed to only copy non-empty files now. |
🔥 [PR Build] Build failed 🔥Build failed for the job 'Detect API changes' Pipeline on Agent |
🔥 [PR Build] Build failed 🔥Build failed for the job 'Build packages' Pipeline on Agent |
|
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 5 tests failed, 218 tests passed. Failures❌ monotouch tests
Html Report (VSDrops) Download ❌ mtouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
/sudo backport release/6.0.3xx |
1 similar comment
|
/sudo backport release/6.0.3xx |
|
Backport Job to branch release/6.0.3xx Created! The magic is happening here |
|
Backport Job to branch release/6.0.3xx Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6397035 for more details. |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6397037 for more details. |
|
/sudo backport release/6.0.4xx |
|
Backport Job to branch release/6.0.4xx Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6401202 for more details. |
…r if they exists on Windows. Fixes #15267. (#15467) The exclusion of partial app manifests happened here, but the commit doesn't explain why: f4a4b23#diff-178de6110858688b9f7c2e8e57a873f5ac9498b355a456bfc18547ab2df876bc It's certainly wrong if the partial app manifest is a part of the project, but this exclusion might be because partial app manifests might be added as a part of the build as well. So change the logic to copy partial app manifests from Windows if they exist there and they're not empty. Fixes #15267. Backport of #15328 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
…r if they exists on Windows. Fixes #15267. (#15460) The exclusion of partial app manifests happened here, but the commit doesn't explain why: f4a4b23#diff-178de6110858688b9f7c2e8e57a873f5ac9498b355a456bfc18547ab2df876bc It's certainly wrong if the partial app manifest is a part of the project, but this exclusion might be because partial app manifests might be added as a part of the build as well. So change the logic to copy partial app manifests from Windows if they exist there and they're not empty. Fixes #15267. Backport of #15328 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
The exclusion of partial app manifests happened here, but the commit doesn't explain why:
f4a4b23#diff-178de6110858688b9f7c2e8e57a873f5ac9498b355a456bfc18547ab2df876bc
It's certainly wrong if the partial app manifest is a part of the project, but
this exclusion might be because partial app manifests might be added as a part
of the build as well.
So change the logic to copy partial app manifests from Windows if they exist
there.
Fixes #15267.