Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds abi parameter so it can be used with proxy, or unverified contracts #18

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

startswithaj
Copy link
Contributor

@startswithaj startswithaj commented Jul 5, 2024

Adds abi parameter which means the decode page can be used programmatically and an abi can be provided for contracts that are proxies or are not verified.

Does not update the encode page.

Adds small UI change to display decoded call params.

When setting the query parameter it should be abi=encodeURIComponent(JSON.stringify(abi))

Copy link

vercel bot commented Jul 5, 2024

Someone is attempting to deploy a commit to the Dawson's projects Team on Vercel.

A member of the Team first needs to authorize it.

@dawsbot
Copy link
Owner

dawsbot commented Jul 6, 2024

Thanks for the submission @startswithaj ! Is there a reason the encode is left out here?

@startswithaj
Copy link
Contributor Author

Cheers @dawsbot, the encode page doesn't take any query params. We would need to add an additional input field for the abi.

It's not important to me because I use decode programmatically, circumventing the encode page all together. If its important to you, I can take a look at adding it in another pr.

@dawsbot
Copy link
Owner

dawsbot commented Jul 8, 2024

@startswithaj I could see this being most helpful in allowing folks to both encode and decode. For now I suppose decode is still valuable for you, but until we add an encode, others won't benefit.

@dawsbot
Copy link
Owner

dawsbot commented Jul 8, 2024

Side note @startswithaj - what project are you using this with? I'd love to chat more about things you'd change or invest effort in if you had the world of resources. DM me on twitter? https://twitter.com/DawsonBotsford

@startswithaj
Copy link
Contributor Author

startswithaj commented Jul 16, 2024

hey @dawsbot its just a one time case thing for me. To sign some tx via a multisig. I can just host this locally for now if you're not keen to merge it. I just thought it would be useful for the hardhad plugin on your readme. I don't use twitter sorry.

Cheers

@dawsbot
Copy link
Owner

dawsbot commented Aug 9, 2024

Hey @startswithaj sorry for my delay on this. I'm pulling this down now

@dawsbot dawsbot merged commit b926cb3 into dawsbot:master Aug 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants