-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary ABI lookup #15
Comments
This is a good suggestion. You're thinking that the ABI itself would also be encoded fully in the URL? I'm interested @ItsNickBarry if you can make the PR |
One way to do it would be to encode the ABI (also suggested by @startswithaj). Another would be to change the I prefer the latter option, but it's a bit harder to do in a backwards-compatible way. |
You only need to encode the part of the abi you need for the function call. For a transfer it would just be
Then process it
Otherwise we could add FnSignature as an additional parameter and if thats set ignore |
That's a good spec proposed @startswithaj - If you want to PR this feel free! It should be possible without a breaking change, which is preferred |
I'm attempting to run a test transaction on a local Hardhat network that's forking a public network. I suppose this isn't supported, because the UI hangs with the message "Fetching contract ABI...".
This tool would much more useful if this step were avoided, and transactions were encoded using only the query string parameters. Even if there might be security reasons to disallow sending transactions without verified contracts and ABIs, this policy prevents multi-step flows from being tested.
The text was updated successfully, but these errors were encountered: