ci: trim branch name for CF preview URLs #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
davidlj95
changed the title
davidlj95
force-pushed
the
stacked/ci-shorten-cf-preview-url
branch
from
3f981e9 to
cf13cbc
Compare
|
🎉 This PR is included in version 2.35.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After checking out a deploy preview, detected that if branch name is too long it gets cut when generating the preview URL.
In one case it was cut to 28 chars but unsure if 28 is the hard limit or if they remove parts (separated by
-)In another case it was also cut to 28 chars so trying with 28 as magic number for now
Worked for this PR:
https://stacked-ci-shorten-cf-previe.davidlj95.pages.dev
🎉