Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace slash with dash for CF preview URLs #288

Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Mar 13, 2024

Otherwise, '/' can't be used in hostname, so results in an incorrect preview URL

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

@davidlj95 davidlj95 force-pushed the stacked/ci-replace-slash-with-dash-for-CF-preview-URLs branch from c60f564 to 2eeaa0e Compare March 13, 2024 13:09
@davidlj95 davidlj95 enabled auto-merge (squash) March 13, 2024 13:09
@davidlj95 davidlj95 merged commit 0906768 into main Mar 13, 2024
9 checks passed
@davidlj95 davidlj95 deleted the stacked/ci-replace-slash-with-dash-for-CF-preview-URLs branch March 13, 2024 13:12
Copy link

🎉 This PR is included in version 2.35.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant