chore(atomic): add component error custom element #5043

y-lakhdar · 2025-03-06T00:06:25Z

AtomicComponentError Component Specification

📝 Requirements

The atomic-component-error is designed to display error messages for other components and log errors to the console.

Functional Requirements:
- Display an error message indicating which component encountered an error.
- Log the error and the associated element to the console.

⚠️ Risks and Challenges

Risk:
- The component might not be used consistently across all components, leading to inconsistent error handling.
Challenge:
- Ensuring that all potential errors are properly caught and displayed by this component.

✅ Checklist

🧪 The component is unit tested
N/A 🧪 The component includes E2E tests (Not necessary)
♿ The component complies with the Web Content Accessibility Guidelines.
N/A 🌐 All strings intended for humans or assistive technology must be localized with i18n. (cannot do it without breaking component logic)
📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
N/A 🎨 CSS parts are documented still accessible. (No parts to expose)
N/A 🦥 Slotted Content, public methods and properties are documented (No slots)

https://coveord.atlassian.net/browse/KIT-4022

github-actions · 2025-03-06T00:11:13Z

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File	Old (kb)	New (kb)
case-assist	246.6	246.6
commerce	359.3	359.3
search	417.3	417.3
insight	408.5	408.5
recommendation	258	258
ssr	411.1	411.1
ssr-commerce	375.8	375.8

dmgauthier

I like the PR Description !

Do we maintain any documentation on how to implement and use the atomic components ?

alexprudhomme

Nice !

packages/atomic/src/components/common/atomic-component-error/atomic-component-error.spec.ts

The base branch was changed.

packages/atomic/src/components/common/atomic-component-error/atomic-component-error.ts

packages/atomic/src/decorators/light-dom.spec.ts

packages/atomic/vitest-utils/testing-helpers/fixture-wrapper.ts

https://coveord.atlassian.net/browse/KIT-4010

https://coveord.atlassian.net/browse/KIT-4032 add component error custom element https://coveord.atlassian.net/browse/KIT-4022 stories https://coveord.atlassian.net/browse/KIT-4022 update story https://coveord.atlassian.net/browse/KIT-4022 Add generated files https://coveord.atlassian.net/browse/KIT-4022 remove unnecessary style attribute https://coveord.atlassian.net/browse/KIT-4022 simplify decorator https://coveord.atlassian.net/browse/KIT-4032 build https://coveord.atlassian.net/browse/KIT-4022 Add generated files

…tomic-component-error.ts Co-authored-by: Frederic Beaudoin <[email protected]>

Co-authored-by: Frederic Beaudoin <[email protected]>

https://coveord.atlassian.net/browse/KIT-4022

- **fix(quantic): fixed issue with custom facet captions inside the refine modal (#5075)** - **fix(quantic): delay caused by recent queries fixed (#5060)** - **[Version Bump][skip ci]: ui-kit publish** - **working**

https://coveord.atlassian.net/browse/KIT-4022

y-lakhdar added the new-lit-component label Mar 6, 2025

y-lakhdar changed the title ~~add component error custom element~~ chore(atomic): add component error custom element Mar 6, 2025

y-lakhdar marked this pull request as ready for review March 6, 2025 03:33

y-lakhdar requested review from a team as code owners March 6, 2025 03:33

y-lakhdar requested review from olamothe, fpbrault, fbeaudoincoveo and alexprudhomme March 6, 2025 03:33

y-lakhdar had a problem deploying to PR Artifacts March 6, 2025 03:42 — with GitHub Actions Error

y-lakhdar force-pushed the KIT-4032 branch 2 times, most recently from 05cea99 to e7684f4 Compare March 6, 2025 14:43

dmgauthier previously approved these changes Mar 6, 2025

View reviewed changes

y-lakhdar force-pushed the KIT-4022 branch 2 times, most recently from 669fbcd to bec043b Compare March 6, 2025 14:56

y-lakhdar had a problem deploying to PR Artifacts March 6, 2025 15:04 — with GitHub Actions Failure

y-lakhdar temporarily deployed to PR Artifacts March 6, 2025 16:33 — with GitHub Actions Inactive

alexprudhomme previously approved these changes Mar 7, 2025

View reviewed changes

packages/atomic/src/components/common/atomic-component-error/atomic-component-error.spec.ts Show resolved Hide resolved

y-lakhdar force-pushed the KIT-4032 branch 2 times, most recently from 41d615d to a23d857 Compare March 7, 2025 14:15

Base automatically changed from KIT-4032 to master March 12, 2025 17:00

fbeaudoincoveo approved these changes Mar 13, 2025

View reviewed changes

y-lakhdar enabled auto-merge March 17, 2025 16:50

y-lakhdar had a problem deploying to PR Artifacts March 17, 2025 16:58 — with GitHub Actions Failure

y-lakhdar force-pushed the KIT-4022 branch from e05653d to 2ee4557 Compare March 18, 2025 14:03

y-lakhdar had a problem deploying to PR Artifacts March 18, 2025 14:12 — with GitHub Actions Failure

y-lakhdar force-pushed the KIT-4022 branch from 3688ec3 to 2ee4557 Compare March 18, 2025 14:29

y-lakhdar and others added 8 commits March 18, 2025 10:44

test(atomic): add testing helpers

1c82080

https://coveord.atlassian.net/browse/KIT-4010

rename folder

ac0f492

https://coveord.atlassian.net/browse/KIT-4010

build

db26a34

Update packages/atomic/src/components/common/atomic-component-error/a…

8d89271

…tomic-component-error.ts Co-authored-by: Frederic Beaudoin <[email protected]>

Update packages/atomic/vitest-utils/testing-helpers/fixture-wrapper.ts

ea56e61

Co-authored-by: Frederic Beaudoin <[email protected]>

apply corrections

b010816

https://coveord.atlassian.net/browse/KIT-4022

build

0897a32

https://coveord.atlassian.net/browse/KIT-4022

y-lakhdar force-pushed the KIT-4022 branch from 2ee4557 to 0897a32 Compare March 18, 2025 14:52

y-lakhdar had a problem deploying to PR Artifacts March 18, 2025 14:58 — with GitHub Actions Failure

add loader for non SSR

9eed305

https://coveord.atlassian.net/browse/KIT-4022

y-lakhdar had a problem deploying to PR Artifacts March 18, 2025 17:42 — with GitHub Actions Failure

louis-bompart and others added 4 commits March 19, 2025 13:35

merge

095cd63

https://coveord.atlassian.net/browse/KIT-4022

chore: update atomic-react build

74d18f4

- **fix(quantic): fixed issue with custom facet captions inside the refine modal (#5075)** - **fix(quantic): delay caused by recent queries fixed (#5060)** - **[Version Bump][skip ci]: ui-kit publish** - **working**

merge

ee3709a

https://coveord.atlassian.net/browse/KIT-4022

build

f3f42e6

https://coveord.atlassian.net/browse/KIT-4022

y-lakhdar had a problem deploying to PR Artifacts March 19, 2025 23:05 — with GitHub Actions Failure

y-lakhdar added 2 commits March 20, 2025 10:19

revert react loader

be26aba

https://coveord.atlassian.net/browse/KIT-4022

green build

937abbe

https://coveord.atlassian.net/browse/KIT-4022

y-lakhdar temporarily deployed to PR Artifacts March 20, 2025 16:43 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(atomic): add component error custom element #5043

chore(atomic): add component error custom element #5043

y-lakhdar commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading

dmgauthier left a comment

alexprudhomme left a comment

chore(atomic): add component error custom element #5043

Are you sure you want to change the base?

chore(atomic): add component error custom element #5043

Conversation

y-lakhdar commented Mar 6, 2025 • edited Loading

AtomicComponentError Component Specification

📝 Requirements

⚠️ Risks and Challenges

✅ Checklist

github-actions bot commented Mar 6, 2025 • edited Loading

Pull Request Report

PR Title

Live demo links

Bundle Size

dmgauthier left a comment

Choose a reason for hiding this comment

alexprudhomme left a comment

Choose a reason for hiding this comment

y-lakhdar commented Mar 6, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025 •

edited

Loading