-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(quantic): delay caused by recent queries fixed #5060
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea for the fix! Nice work. Do you have a before/after comparison of the performance impact? I wonder if the caching had more an impact or if the max amount of suggestions stored is the biggest factor here.
After discussion with @mmitiche , We should instead rely on the And keep the resulting in a "cache" so we don't have to re-compute the expensive operations every single time we re-render. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions
packages/quantic/force-app/main/default/lwc/quanticSearchBox/quanticSearchBox.js
Outdated
Show resolved
Hide resolved
...orce-app/main/default/lwc/quanticSearchBoxSuggestionsList/quanticSearchBoxSuggestionsList.js
Outdated
Show resolved
Hide resolved
...orce-app/main/default/lwc/quanticSearchBoxSuggestionsList/quanticSearchBoxSuggestionsList.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSearchBox/quanticSearchBox.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a before/after comparison in terms of performance? Just out of curiosity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a weird corner case that we're not checking for I'm fairly certain
...orce-app/main/default/lwc/quanticSearchBoxSuggestionsList/quanticSearchBoxSuggestionsList.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
SFINT-6021