fix(quantic): delay caused by recent queries fixed

[mmitiche]

SFINT-6021

• Reduced the maximum amount of recent queries to save in the local storage to 10.
• Optimized the function that were doing some computation in the QuanticSearchBoxSuggestionsList by making them only run when necessary, in order to do this computation is only executed when the relevant dependant properties change values, this was made using setters methods tied to these properties.

[github-actions]

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

• Storybook

• Playwright report

Bundle Size

File	Old (kb)	New (kb)	Change (%)
case-assist	246.6	246.6	0
commerce	359.2	359.2	0
search	417.3	417.3	0
insight	408.5	408.5	0
recommendation	258	258	0
ssr	411.1	411.1	0
ssr-commerce	375.7	375.7	0

[SimonMilord]

I like the idea for the fix! Nice work. Do you have a before/after comparison of the performance impact? I wonder if the caching had more an impact or if the max amount of suggestions stored is the biggest factor here.

[erocheleau]

After discussion with @mmitiche ,

We should instead rely on the setters for the query suggestions and lastQueries to decide when we want to re-compute the arrays of suggestions/recent queries.

And keep the resulting in a "cache" so we don't have to re-compute the expensive operations every single time we re-render.

[erocheleau]

Couple of questions

[SimonMilord]

Do you have a before/after comparison in terms of performance? Just out of curiosity?

[mmitiche]

Do you have a before/after comparison in terms of performance? Just out of curiosity?

Yes, these screenshots shows how many times the methods getSuggestionListOption and getQuerySuggestionsNotInRecentQueries and the render method have been called when writing one character in the search box:

Before:

After:

[erocheleau]

There's a weird corner case that we're not checking for I'm fairly certain

[erocheleau]

Nice