ui: replace Qt spinner and text with python spinner and text #34887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
requested changes
Mar 16, 2025
UI PreviewAll Screenshots
|
deanlee
force-pushed
the
ui_remove_qt_spinner_text
branch
7 times, most recently
from
cffd213 to
e5198ba
Compare
adeebshihadeh
requested changes
Mar 20, 2025
system/athena/registration.py
Outdated
| if show_spinner: | ||
| spinner.close() | ||
| with ThreadPoolExecutor(max_workers=1) as executor: |
There was a problem hiding this comment.
we shouldn't have to change the consumers of spinner/text. if we have to use the wrapper for that, that's fine
There was a problem hiding this comment.
y, Moving the spinner into a separate thread is a better approach than moving the register process to a thread. This requires fewer changes to the original code while ensuring the spinner doesn't freeze or get blocked during the registration process.
deanlee
force-pushed
the
ui_remove_qt_spinner_text
branch
2 times, most recently
from
8dece6f to
9ff4793
Compare
deanlee
force-pushed
the
ui_remove_qt_spinner_text
branch
from
9ff4793 to
7927c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.