loggerd: add unit tests and fix identified sync issues #34840
+217
−72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #34839
This PR adds unit tests specifically aimed at resolving synchronization issues between encoderd and loggerd. While existing tests thoroughly cover logger rotation, these new test cases address the previously untested logic for synchronizing encoder segment numbers with logger segment numbers.
Key Changes:
LoggerdState
andRemoteEncoder
classes were moved tologgerd.h
.RemoteEncoder::syncSegment
, which can now be unit tested.Future Improvements:
As part of future work,
loggerd.h
can be split to separate configuration and logic. For instance, renamingloggerd.h
toencoder_config.h
and limitingloggerd.h
to only contain declarations used byloggerd.cc
. However, since this would introduce substantial changes, it will be addressed in a follow-up PR.