Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement PWA #252

Merged
merged 21 commits into from
Mar 27, 2025
Merged

feat: implement PWA #252

merged 21 commits into from
Mar 27, 2025

Conversation

incognitojam
Copy link
Member

@incognitojam incognitojam commented Mar 27, 2025

closes #59

TODOs

  • manifest
  • splash screen (do we still need to generate these?)
  • cache fonts
  • service worker
    • install SW
    • prompt for update, better than interrupting user maybe autoupdate is fine?
  • offline experience
    • still loads when offline
    • indicate that the device is offline
  • test on ios
  • test on android

@incognitojam incognitojam added the enhancement new feature or request label Mar 27, 2025
Copy link

github-actions bot commented Mar 27, 2025

Changes:

path lines diff
./pages/offline.tsx 21 +21
./pwa.ts 19 +19
./App.tsx 30 +12
./index.tsx 15 +1

Total lines: 4246 (+53)

Copy link

github-actions bot commented Mar 27, 2025

deployed preview: https://252.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@incognitojam
Copy link
Member Author

incognitojam commented Mar 27, 2025

seems to be an issue signing in, at least on iOS - see #253

@incognitojam
Copy link
Member Author

image
image

@incognitojam
Copy link
Member Author

incognitojam commented Mar 27, 2025

Happens on iOS on this PR (same behaviour in safari and firefox, both use same engine on iOS?)

incognitojam added a commit that referenced this pull request Mar 27, 2025
Fixes an issue related to CORS on stricter browsers (e.g. Safari)

Resolves #253 seen in #252
@incognitojam incognitojam marked this pull request as ready for review March 27, 2025 23:00
@incognitojam incognitojam marked this pull request as draft March 27, 2025 23:07
@incognitojam incognitojam marked this pull request as ready for review March 27, 2025 23:11
@incognitojam incognitojam merged commit f94512f into master Mar 27, 2025
7 checks passed
@incognitojam incognitojam deleted the vite-pwa branch March 27, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PWA features
1 participant