Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PWA features #59

Closed
adeebshihadeh opened this issue Jul 11, 2024 · 9 comments · Fixed by #252
Closed

Implement PWA features #59

adeebshihadeh opened this issue Jul 11, 2024 · 9 comments · Fixed by #252
Labels
bounty comma.ai/bounties enhancement new feature or request
Milestone

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Jul 11, 2024

This issue is for making this a complete PWA, including but not limited to:

  • icons
  • splash screen
  • a defined offline mode (doesn't have to do anything, except say "connect offline")

As well as testing the PWA-ness in CI.

@adeebshihadeh adeebshihadeh added bounty comma.ai/bounties enhancement new feature or request labels Jul 11, 2024
@adeebshihadeh adeebshihadeh added this to the 1.0 milestone Jul 11, 2024
@adeebshihadeh
Copy link
Contributor Author

This looks interesting https://github.com/elegantapp/pwa-asset-generator

@seanaguinaga
Copy link

seanaguinaga commented Jul 12, 2024

How's this: #68

Oops need to add CI - standby

@griffinbaker12
Copy link
Contributor

griffinbaker12 commented Jul 12, 2024

Just a thought on the design for the exit screen I was working on:

Image

The asset generator linked above also integrates really well with the rest of the project. I ran:

npx pwa-asset-generator ./public/images/icon-vector.svg ./temp -b "#141414" -m public/manifest.json -i ./index.html

to make sure the app's bg on the phone screen matched that of the svg icon.

If helpful, you can find the approach I was taking here.

@theVedanta
Copy link

Hello,
Is this issue closed? I would like to try this out

@namnbk
Copy link

namnbk commented Oct 4, 2024

Is this still available?

@griffinbaker12
Copy link
Contributor

griffinbaker12 commented Oct 4, 2024

anything not closed is open, but they aren't focusing on this rn
@theVedanta @namnbk

@pedrosimao
Copy link

Hey, I see there are two PRs open since October 2024. Is it still open for a bounty? And why did the PRs did not get merge?

@Eunanibus
Copy link

I'm also curious. If the work to combat these bounties isn't being merged, I don't want to tackle in-progress tasks without understanding why.

@incognitojam
Copy link
Member

From what I can see none of the PRs are in a mergeable state (received review comments and not updated, need rebasing). I'll be looking at this in the next couple days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty comma.ai/bounties enhancement new feature or request
Projects
Status: Done
Status: Done
8 participants