-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Fixes allow brave://settings/search/defaultSearch deep link #28190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Missed when adding brave/brave-browser#42999, thanks |
Chromium major version is behind target branch (134.0.6998.95 vs 135.0.7049.17). Please rebase. |
Released in v1.78.56 |
Verified with
non rewardsNote: the target url points to Verified link points Verified clicking the ad opens rewards |
Resolves brave/brave-browser#44745
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Confirm ads can deep link to chrome://settings/search/defaultSearch