Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Fixes allow brave://settings/search/defaultSearch deep link #28190

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 18, 2025

Resolves brave/brave-browser#44745

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm ads can deep link to chrome://settings/search/defaultSearch

@tmancey tmancey requested a review from a team as a code owner March 18, 2025 15:02
Copy link
Collaborator

@aseren aseren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey
Copy link
Collaborator Author

tmancey commented Mar 18, 2025

Missed when adding brave/brave-browser#42999, thanks

@tmancey tmancey changed the title [ads] Allow brave://settings/search/defaultSearch deep link [ads] Fixes brave://settings/search/defaultSearch deep link Mar 18, 2025
@tmancey tmancey changed the title [ads] Fixes brave://settings/search/defaultSearch deep link [ads] Fixes allow brave://settings/search/defaultSearch deep link Mar 18, 2025
Copy link
Contributor

Chromium major version is behind target branch (134.0.6998.95 vs 135.0.7049.17). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Mar 19, 2025
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Mar 19, 2025
@tmancey tmancey merged commit faf484c into master Mar 20, 2025
18 checks passed
@tmancey tmancey deleted the issues/44745 branch March 20, 2025 14:38
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Mar 20, 2025
brave-builds added a commit that referenced this pull request Mar 20, 2025
brave-builds added a commit that referenced this pull request Mar 20, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.56

@btlechowski
Copy link

Verified with

Brave 1.78.58 Chromium: 135.0.7049.26 (Official Build) nightly (64-bit)
Revision e2eeb23
OS Linux

non rewards

Note: the target url points to chrome://settings/search/defaultSearch

Verified link points brave://settings/search/defaultSearch
image

Verified clicking the ad opens brave://settings/search/defaultSearch

image

rewards

Note: the target url points to chrome://settings/search/defaultSearch

Verified link points brave://settings/search/defaultSearch
image

Verified clicking the ad opens brave://settings/search/defaultSearch

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Allow brave://settings/search/defaultSearch deep link
4 participants