Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Allow brave://settings/search/defaultSearch deep link #44745

Closed
tmancey opened this issue Mar 18, 2025 · 2 comments · Fixed by brave/brave-core#28190
Closed

[ads] Allow brave://settings/search/defaultSearch deep link #44745

tmancey opened this issue Mar 18, 2025 · 2 comments · Fixed by brave/brave-core#28190
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.76.x - Release #7

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 18, 2025 •
edited
Loading

No description provided.

@tmancey tmancey added bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude labels Mar 18, 2025
@tmancey tmancey self-assigned this Mar 18, 2025
@tmancey tmancey added this to Ads Mar 18, 2025
@github-project-automation github-project-automation bot moved this to New issues in Ads Mar 18, 2025
@tmancey tmancey moved this from New issues to Review in Ads Mar 18, 2025
@tmancey tmancey mentioned this issue Mar 18, 2025
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from Review to Done in Ads Mar 20, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 20, 2025
This was referenced Mar 20, 2025
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.76.82 or higher for 1.76.x verification 👍

@btlechowski
Copy link

Verified with

Brave 1.76.82 Chromium: 134.0.6998.178 (Official Build) (64-bit)
Revision 4945fe87e209cb2e9d6a37ff68d2c805f9c2bf9e
OS Linux

non rewards

Note: the target url is chrome://settings/search/defaultSearch

Verified link points brave://settings/search/defaultSearch

Image

Verified clicking the ad opens brave://settings/search/defaultSearch

Image

rewards

Note: the target url is chrome://settings/search/defaultSearch

Verified link points brave://settings/search/defaultSearch

Image

Verified clicking the ad opens brave://settings/search/defaultSearch

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.76.x - Release #7
Development

Successfully merging a pull request may close this issue.

[ads] Fixes allow brave://settings/search/defaultSearch deep link brave/brave-core
4 participants
@tmancey @kjozwiak @btlechowski @brave-builds