[#3234] - move select all checkbox to accordion #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muloem
requested changes
Oct 16, 2019
There was a problem hiding this comment.
I think in the situations where it turns out that all devices in a group have been selected, then the checkbox for the select all devices should also become checked in that moment. And as soon as not all devices are checked, e.g. one is deselected, then that checkbox should also be automatically deselected.
muloem
reviewed
Oct 16, 2019
|
I think we can consider adding this for the next release round. |
|
I agree. Let's get the already tested batch of changes out and push this to the next round |
muloem
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist