Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle differently 'Select all' devices in assignments #3234

Closed
janagombitova opened this issue Oct 15, 2019 · 1 comment
Closed

Handle differently 'Select all' devices in assignments #3234

janagombitova opened this issue Oct 15, 2019 · 1 comment
Assignees
@marvinkome
Labels
1 - Assignment UI
Milestone
1.10.1

Comments

@janagombitova
Copy link
Contributor

The 'Select all' can be handled more elegantly by adding a checkbox to the level of the device group. @marvinkome is that too much work to squeeze in today?
Screen Shot 2019-10-15 at 14 27 17

Originally posted by @janagombitova in #3230 (comment)
@janagombitova janagombitova modified the milestone: 1.10.1 Oct 15, 2019
marvinkome pushed a commit that referenced this issue Oct 16, 2019
[#3234] - move select all checkbox to accordion
729d81d
marvinkome pushed a commit that referenced this issue Oct 16, 2019
[#3234] - update devices tests
90ed6c2
@janagombitova janagombitova added this to the 1.10.1 milestone Oct 17, 2019
marvinkome pushed a commit that referenced this issue Oct 17, 2019
[#3234] - make select all options change automatically
b57c8c7
marvinkome pushed a commit that referenced this issue Oct 25, 2019
Merge pull request #3237 from akvo/issue-3234/handle-select-all-diffe…
6dcc02c 
…rently

[#3234] - move select all checkbox to accordion
@janagombitova
Copy link
Contributor Author

Better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinkome marvinkome

Labels
1 - Assignment UI
Projects
None yet
Milestone
1.10.1
Development

No branches or pull requests
2 participants
@janagombitova @marvinkome