-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/3192 move assignments edit to react #3206
Conversation
* We do this because we have not yet fully migrated the contents of the surveyIds property to the formIds property. Once that is complete we no longer need this commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard/app/js/lib/components/devices/AssignmentsEditView/index.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/devices/AssignmentsEditView/index.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/devices/AssignmentsEditView/index.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/devices/AssignmentsEditView/index.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/selectors/DeviceSelector/index.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/selectors/DeviceSelector/index.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/selectors/FolderSurveySelector/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When selecting to edit an assignment, the survey that the assignment is associated with shown as active/selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Create a new assignment
- Give a name and start date
- Try to save and saving is not allowed (as expected)
- Add an end date
- Select a folder and survey but do not select any forms
- Try to save
- The assignment is saved even when no forms or devices are selected.
@janagombitova @Kiarii from user perspective, should we enforce that at least one form and device need to be selected before enabling saving an assignment?
Also I believe the Save Assignment
button should probably be grey to highlight that its disabled (but @Kiarii can give better guidance on that)
…ithub.com/akvo/akvo-flow into issue/3192-move-assignments-edit-to-react
I think requiring the selection of all mandatory items is fine, we might need to indicate to the user of what is still un-selected if they hit the [save assignment] before completing all fields.. |
Move whole assignment edit view to react
Checklist