Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/3192 move assignments edit to react #3206

Merged
merged 33 commits into from
Oct 10, 2019

Conversation

marvinkome
Copy link
Contributor

@marvinkome marvinkome commented Sep 27, 2019

Move whole assignment edit view to react

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@marvinkome marvinkome requested a review from muloem September 27, 2019 14:22
Copy link
Member

@muloem muloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on the button to create a new assignment, it ends in a blank screen and I get the following in the console.

Screenshot 2019-09-30 at 15 46 42

Copy link
Member

@muloem muloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When selecting to edit an assignment, the survey that the assignment is associated with shown as active/selected.

Copy link
Member

@muloem muloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I create an assignment and save, the pop up about missing requirements shows up. It shouldnt because I filled in everything. Also when I reload the screen the assignment is no longer in the list of my created assignments.

assignments-list

Copy link
Member

@muloem muloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changing the selected folder/survey in the survey selector, the list of forms from the previous selection is still shown. Ideally, we would like this list to be emptied whenever a new folder is selected.

assignments-folder-selector

Copy link
Member

@muloem muloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Create a new assignment
  • Give a name and start date
  • Try to save and saving is not allowed (as expected)
  • Add an end date
  • Select a folder and survey but do not select any forms
  • Try to save
  • The assignment is saved even when no forms or devices are selected.

assignments-disable-save-button

@janagombitova @Kiarii from user perspective, should we enforce that at least one form and device need to be selected before enabling saving an assignment?

Also I believe the Save Assignment button should probably be grey to highlight that its disabled (but @Kiarii can give better guidance on that)

@janagombitova
Copy link
Contributor

janagombitova commented Oct 8, 2019

@muloem I agree. All mandatory items should be selected before an assignment can be saved, thus also at least one form and one device

I prefer disabling the button rather than having popups. But indeed this is @Kiarii's call

@muloem
Copy link
Member

muloem commented Oct 8, 2019

An assignment is created even when the save assignment button is supposed to be disabled.
However, when the page is reloaded, it disappears from the list.

assignment-with-disbaled-save

@Kiarii
Copy link

Kiarii commented Oct 8, 2019

@muloem I agree. All mandatory items should be selected before an assignment can be saved, thus also at least one form and one device

I prefer disabling the button rather than having popups. But indeed this is @Kiarii's call

I think requiring the selection of all mandatory items is fine, we might need to indicate to the user of what is still un-selected if they hit the [save assignment] before completing all fields..

@muloem muloem merged commit 17253ec into develop Oct 10, 2019
@muloem muloem deleted the issue/3192-move-assignments-edit-to-react branch December 3, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants