Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move assignments edit views to react view #3192

Closed
marvinkome opened this issue Sep 19, 2019 · 2 comments
Closed

Move assignments edit views to react view #3192

marvinkome opened this issue Sep 19, 2019 · 2 comments
Assignees
@marvinkome
Milestone
1.10 Worshipped W...

Comments

@marvinkome
Copy link
Contributor

Make assignments-edit-view to react container view
@marvinkome marvinkome self-assigned this Sep 19, 2019
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - add jsconfg for module alias resolve in vscode
aec7d3d
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - merge with assignment/ui
27904de
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - add .vscode config to gitignore
d38d5cc
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - setup wrapper component for assignment edit view
b0bdc6e
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - add form selector to wrapper
f6df7bf
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - move device selector didInsert to cDM in react component
cc2e4fa
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - Add validation for assignment name
728f242
marvinkome pushed a commit that referenced this issue Sep 26, 2019
[#3192] - add assignment save details
37f9355
muloem added a commit that referenced this issue Sep 27, 2019
@muloem
[#3192] Ensure that formIds are returned by looking up the surveyIds
8803a75 
* We do this because we have not yet fully migrated the contents of the surveyIds property to the formIds property. Once that is complete we no longer need this commit
marvinkome pushed a commit that referenced this issue Sep 27, 2019
[#3192] - update ui model for selected survey assignment
04cbafc
marvinkome pushed a commit that referenced this issue Sep 27, 2019
[#3192] - final cleanups
5eac7b0
marvinkome pushed a commit that referenced this issue Sep 27, 2019
[#3192] - fix merge conflicts
f690021
marvinkome pushed a commit that referenced this issue Sep 27, 2019
[#3192] - remove old assignment-edit-view
f3945a8
marvinkome pushed a commit that referenced this issue Sep 30, 2019
[#3192] - remove duplicate folder selector
f723c82
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3192] - remove old folder selector from views imports
dd60797
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3192] - add check in forms setup to see if a selected assigment is …
ac3b7d9 
…present
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3192] - update eslint anchor rule. Change 'a' to 'button'
ba74fa2
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3192] - refactor assignment validation
fcdbb54
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3192] - add date validation and remove FLOW dialog
0a93300
marvinkome pushed a commit that referenced this issue Oct 2, 2019
[#3192] - swtich to 'a' tag to 'button' tag
4b16a83
marvinkome pushed a commit that referenced this issue Oct 4, 2019
[#3192] - remove Flow dependency from FolderSurveySelector component
23af230
marvinkome pushed a commit that referenced this issue Oct 4, 2019
[#3192] - remove FLow from device selector component
b856a85
marvinkome pushed a commit that referenced this issue Oct 7, 2019
[#3192] - changed deviceIsChecked to deviceGroupIsActive
ffeffd1
marvinkome pushed a commit that referenced this issue Oct 7, 2019
[#3192] - remove unused comments
8ae6d0a
marvinkome pushed a commit that referenced this issue Oct 7, 2019
[#3192] - show selected survey when editing
6cc72a6
marvinkome pushed a commit that referenced this issue Oct 8, 2019
[#3192] - add surveyId to model
768e51d
marvinkome pushed a commit that referenced this issue Oct 8, 2019
[#3192] - empty forms when a new survey folder is selected
a600c2e
muloem added a commit that referenced this issue Oct 8, 2019
@muloem
[#3192] Clear out error message if all required parameters are present
761eab1
marvinkome pushed a commit that referenced this issue Oct 8, 2019
[#3192] - add validation for devices and survey
7412f08
marvinkome pushed a commit that referenced this issue Oct 10, 2019
[#3192] - add validation to after submit. replace alert with FLOW dialog
4d61fed
muloem added a commit that referenced this issue Oct 10, 2019
@muloem
Merge pull request #3206 from akvo/issue/3192-move-assignments-edit-t…
17253ec 
…o-react

[#3192] Migrate assignments edit page to react
@janagombitova
Copy link
Contributor

Is the work here done and is there anything user-visible to test @marvinkome ?

@marvinkome
Copy link
Contributor Author

Yes. This is basically the issue for the whole assignment view. Yup, work here is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinkome marvinkome

Labels
None yet
Projects
None yet
Milestone
1.10 Worshipped Wolfbane
Development

No branches or pull requests
2 participants
@janagombitova @marvinkome