[#3040]Add script to make all app URLs https. #3100
Conversation
| String newurl = oldurl.replaceFirst("http:", "https:"); | ||
| String appcode = (String) da.getProperty(APPCODE_PROP); | ||
| if (!newurl.equals(oldurl) | ||
| // && appcode.equals(APPCODE_VALUE) //Only modern apps? |
There was a problem hiding this comment.
can we maybe remove this commented out code or is it necessary?
There was a problem hiding this comment.
That was something I wanted feedback on; should we change only the URLs with the modern code?
There was a problem hiding this comment.
Right, I have seen there is also fieldSurvey... no idea, who uses those anyway?
There was a problem hiding this comment.
satStat is no longer used in the latest versions of the app
There was a problem hiding this comment.
I think fieldSurvey used to be the name of the app. But since the old versions will become unreachable if we do not modify all URLs, I propose to simply change all of them.
| $APP_ID \ | ||
| $SERVICE_ACCOUNT \ | ||
| $P12_FILE_PATH \ | ||
| $2 $3 |
There was a problem hiding this comment.
is it necessary to pass $3? if I understand correctly $1 is the instance name, $2 is the [--doit] param, right?
There was a problem hiding this comment.
Cut-and-paste, obviously.
Before the PR (what is the issue or what needed to be done)
S3 will stop supporting unencrypted fetches.
The solution
Iterate over app URLs and change http: to https:
Screenshots (if appropriate)
Checklist