Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apk download url needs to be HTTPS #3040

Closed
valllllll2000 opened this issue Apr 2, 2019 · 2 comments
Closed

Apk download url needs to be HTTPS #3040

valllllll2000 opened this issue Apr 2, 2019 · 2 comments

Comments

@valllllll2000
Copy link
Contributor

valllllll2000 commented Apr 2, 2019

We currently have a json rest api the app queries:
/deviceapprest
This service returns a json object with amongst other contains the url to download the apk using the DeviceApplication entity of the datastore. The url field is always http. When updating the android tools with Android 28, there is a new feature enabled by default which is to prohibit http calls. For now I have disabled that setting (due to the support url and device time) and also I am replacing http by https when downloading the apk but it would be nice to start using https for these urls as both urls work.
see: https://developer.android.com/training/articles/security-config#CleartextTrafficPermitted for more info

@stellanl
Copy link
Contributor

stellanl commented Apr 2, 2019

Two approaches:

  1. Change ApkRedirectServlet to modify the URL from the DeviceApplication table.
  2. Change the (script?) code that inserts new URLs in DeviceApplication during deployment. We could also make a datascript that modifies all the old URLs.

@muloem
Copy link
Member

muloem commented Apr 3, 2019

I would vote for option 2, i.e. what is put in is what comes out. No surprises and having to always remember that there is somewhere that the URL gets modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants