-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apk download url needs to be HTTPS #3040
Comments
Two approaches:
|
I would vote for option 2, i.e. what is put in is what comes out. No surprises and having to always remember that there is somewhere that the URL gets modified. |
stellanl
added a commit
that referenced
this issue
May 20, 2019
stellanl
added a commit
that referenced
this issue
May 20, 2019
valllllll2000
pushed a commit
that referenced
this issue
May 21, 2019
[#3040]Add script to make all app URLs https.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently have a json rest api the app queries:
/deviceapprest
This service returns a json object with amongst other contains the url to download the apk using the DeviceApplication entity of the datastore. The url field is always http. When updating the android tools with Android 28, there is a new feature enabled by default which is to prohibit http calls. For now I have disabled that setting (due to the support url and device time) and also I am replacing http by https when downloading the apk but it would be nice to start using https for these urls as both urls work.
see: https://developer.android.com/training/articles/security-config#CleartextTrafficPermitted for more info
The text was updated successfully, but these errors were encountered: