[#2231] Remove surveyalvalue entity #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nces * Also we remove the code duplication where QuestionAnswerStore entities are deleted. It all happens in the `SurveyInstanceDAO.deleteSurveyInstance()` method
…veyedLocale entities
stellanl
approved these changes
May 20, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR (what is the issue or what needed to be done)
The
SurveyalValueentity was implemented with the idea of denormalising data in order to make it more easily accessible given the nature of the google datastore. However its a duplicated entity that has resulted in outdated/erroneuous data being displayed.The solution
We have converted most parts of the system that relied on this entity to use the original source of data
QuestionAnswerStoreso now we remove the code that is to do with retrieving this entity. A follow up PR will remove the entity and its DAO code.Screenshots (if appropriate)
Checklist