Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup SurveyalValue SurveyalValueDao #2231

Closed
valllllll2000 opened this issue Aug 30, 2017 · 0 comments
Closed

Cleanup SurveyalValue SurveyalValueDao #2231

valllllll2000 opened this issue Aug 30, 2017 · 0 comments
Milestone
1.9.47 Tweedy Tulip

Comments

@valllllll2000
Copy link
Contributor

After making the change in the task #2229 the surveyalValue field is no longer used for data point retrieval. We should list where these values are used and if possible remove them.
Here are the classes that use for SurveyalValue

  • SurveyalRestServlet
  • DataProcessorRestServlet
  • DataProcessorRestServlet
  • KMLGenerator
  • PlacemarkDetailsRestService
  • QuestionAnswerRestService
  • SurveyEventNotificationHandler

SurveyalValueDao:

  • DataProcessorRestServlet
  • SurveyRestService
  • QuestionDao
  • QuestionGroupRestService
  • QuestionRestService
  • SurveyRestService
  • SurveyInstanceDAO
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Remove code for updating fields in SurveyalValue entities
fa263b6
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Stop updating the SurveyalValue when updating question responses
43c5e10
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Remove unused imports and update copyright year
ea0ea36
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Rename variable and delete misleading comment
b9a9a68
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Bypass checking the surveyal values when deleting SurveyInsta…
12b9770 
…nces

* Also we remove the code duplication where QuestionAnswerStore entities are deleted. It all happens in the `SurveyInstanceDAO.deleteSurveyInstance()` method
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Remove checks for surveyal value entities when deleting surveys
8ada53f
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Remove checks for surveyal values when deleteing questions
13068e0
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Remove checks for surveyal values when deleting a question group
8e493aa
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Fix copyright dates and remove unused imports
15762d4
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Remove code for creation of Surveyal values when creating Sur…
ffacba0 
…veyedLocale entities
muloem added a commit that referenced this issue May 15, 2019
@muloem
[#2231] Remove reference to surveyal values from SurveyedLocale entities
fb6e7e0
muloem added a commit that referenced this issue May 16, 2019
@muloem
[#2231] Remove ununsed imports
75fa32d
muloem added a commit that referenced this issue May 17, 2019
@muloem
[#2231] Remove SurveyalValue index definition
ab905e8
muloem added a commit that referenced this issue May 17, 2019
@muloem
[#2231] Upgrade the spring libraries in use
e550971
muloem added a commit that referenced this issue May 17, 2019
@muloem
[#2231] Use fixed versions in package-lock.json
cb0e48b
muloem added a commit that referenced this issue May 17, 2019
@muloem
[#2231] Fix security warning for npm package
2381e44
@muloem muloem added this to the 1.9.47 T... T... milestone May 17, 2019
stellanl added a commit that referenced this issue May 20, 2019
@stellanl
Merge pull request #3096 from akvo/issue/2231-remove-surveyalvalue
b51290c 
[#2231] Remove surveyalvalue entity
valllllll2000 pushed a commit that referenced this issue May 21, 2019
Merge pull request #3102 from akvo/issue/2231-remove-surveyalvalue-part2
406b8e2 
[#2231] Remove SurveyalValue DAO, domain class and indexes definition
@muloem muloem mentioned this issue Nov 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.47 Tweedy Tulip
Development

No branches or pull requests
3 participants
@muloem @valllllll2000 @janagombitova