Jshooks [DO NOT MERGE] #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger_last_time, ledger_nonce, ledger_keylet
…ubfield slot_type slot_float compiling not tested
… float_sum float_sto float_sto_set float_invert float_divide float_one float_mantissa float_sign float_int float_log float_root
Co-authored-by: tequ <[email protected]>
Co-authored-by: tequ <[email protected]>
tequdev
reviewed
Mar 3, 2025
| RETURNJS_IF_INVALID_FLOAT(*f1); | ||
|
|
||
| if (*f1 == 0) | ||
| returnJS(0); |
There was a problem hiding this comment.
float_mantissa
The success value should be returned by XFL(bigint).
Suggested change
| returnJS(0); | |
| returnJSXFL(0); |
| int32_t exp = *e; | ||
|
|
||
| if (mantissa == 0) | ||
| returnJS(0); |
There was a problem hiding this comment.
float_set
The success value should be returned by XFL.
Suggested change
| returnJS(0); | |
| returnJSXFL(0); |
| returnJS(INVALID_ARGUMENT); | ||
|
|
||
| if (*float1 == 0) | ||
| returnJS(0); |
There was a problem hiding this comment.
float_negate
The success value should be returned by XFL.
Suggested change
| returnJS(0); | |
| returnJSXFL(0); |
tequdev
reviewed
Mar 11, 2025
Comment on lines
+346
to
+348
| JSVM_ERROR = 4, | ||
| LEDGER_ERROR = | ||
| 5, // if the ledger contained for example a nonsense hookapi number |
There was a problem hiding this comment.
If the Instruction Limit is reached, the ExitType is currently set to UNSET, but it may be worth adding a new ExitType(INSTRUCTION_LIMIT_REACHED) for this case.
tequdev
reviewed
Mar 17, 2025
There was a problem hiding this comment.
https://github.com/Xahau/xahaud/blob/jshooks/src/quickjs/quickjs.c#L43359
Either Math.random() should not be used, or the implementation should be changed to give deterministic results.
* add tests for fee_base, ledger_keylet, meta_slot * clang-format * clang-format * update SetJSHook_wasm.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)