[JSHooks] Add sto tests #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sublimator
reviewed
Mar 11, 2025
| env.fund(XRP(10000), bob); | ||
|
|
||
| TestHook hook = jswasm[R"[test.hook]( | ||
| const ASSERT = (x) => { |
There was a problem hiding this comment.
Just a comment:
ASSERT_EQ that traced the arguments would be nice for debug
sublimator
reviewed
Mar 12, 2025
| { | ||
| const buf = sto_erase(sto, 0x80002) | ||
| // TODO: https://github.com/Xahau/xahaud/issues/459 | ||
| // ASSERT(buf === DOESNT_EXIST) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Since I have not changed the file in this PR, I will leave the formatting to the JSHooks main PR.
|
Oh, it was a potential fix for the issue
I just pasted it in cause had to get my daughter
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
add tests for
sto_erasesto_from_jsonsto_subarraysto_subfieldsto_to_jsonsto_validateContext of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)