Remove RCPP_USING_CXX11 which is now implicit #1369
Merged
+29
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, under the umbrella of meta issue #1365, builds upon PRs #1367 and #1364. It is a little simpler as it merely removed
RCPP_USING_CXX11wherever it is used (given that it is now always#define'd) and removes the stale#elsecases, if any. It all fit into one commit.A reverse-depends run has been started and is about 100 packages in, this is not expected to reveal anything but we may as well let it run its course again.
Checklist
R CMD checkstill passes all tests