-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use variadic templates unconditionally #1367
Conversation
Remove four generated files
Remove one generated file
Remove one generated file
Remove one generated file
Remove one generated file
and also in InternalFunctionWithStdFunction.h Remove one generated file
Remove nine generated files
and traits/named_object.h
Remove one generated file
Remove one generated file
Remove one generated file
Remove one generated file
I was a little surprised it amounted to so little in the tar.gz:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Been burned before so I will probably await the reverse-depends. Maybe just maybe somone relied on the define. Otherwise this is pretty easy (if volumunious): no new code, only removal of code we no longer compiled in. Seemingly no fat-fingered typo ... 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
As described in #1366 and building on PR #1364, we can simplify the code by no longer switching based on definition of
HAS_VARIADIC_TEMPLATE
: only the positive case will be considered given the baseline of C++11.So this PR removed this file by file, testing each commit locally in CI and arrived at removing the definition. A reverse dependency check is now running as well.
Checklist
R CMD check
still passes all tests