Add blindsigning and summary display #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r for bagl. It simplifies maintainance.
…-settings Make nano home page according to Ledger app boilerplate
Options are "For Large Tx", "ON", "OFF" Update snapshots for nano
Also reduce `BUFF_LEN` to its smallest possible size so that the tests continue to pass
Reduce the global struct size
Operations: - stake - unstake - finalize_unstake - set_delegate_parameters Check: - display - complexity
…ing-ops Remove expert mode for `stake`/`unstake`/`finalize_unstake`
- Summary of information provided later
…ee to be dual used for swap and summary. No tests failed and amounts are accurate for both swap and batch transaction. Co-authored-by: Sébastien Palmer <[email protected]>
…tions, total amount and total fee. Co-authored-by: Sébastien Palmer <[email protected]>
- a basic too long operation with many different operations - a too long operation with only transactions - a too long transaction without fee or amount
…f-screens-displayed-for-review Limit the number of screens displayed for signing review for Nano
…rning-once Maximum one expert-mode warning per signing flow
…-operation-warning-on-parsing-error [summary] remove too long operation warning on parsing error
* Simplify blindsigning code and Use nbgl_useCaseReviewStreamingBlindSigningStart for stax * Extract common ui_stream functions in ui_stream_common for clarity Remove redundant code * Add summary signing flow. It should show warning screens and summary pages
* [blind] add blindsign question to jump to blindsign with blind ON Otherwise, use the clearsign flow as the option was Large Tx * [too_many_screen] reduce number of screen for NanoS+ and NanoX to 12
* Add contact information in info * Swith to large tx mode in BLINDSIGN ON mode if user does not press skip
* [sign-warning] uniform warning between nanos, nanos+ and nanox * [blind] add warnings before going to blindsign flow
- OFF is the default value
Redundant with test_sign_too_long_operation tests
- no more limit of screens (even in Blind mode ON) - no more warning screens for too many screen - large tx option acts like Blind mode OFF Co-authored-by: Ajinkya <[email protected]>
- OFF is the default value Co-authored-by: Ajinkya <[email protected]>
- change blindsining mode settings from ChoiceList to Switch for stax Co-authored-by: Ajinkya <[email protected]>
Stax-remove-bs-large-tx
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #define EXPERT_MODE 0x01 | ||
| #define BACK 0x02 | ||
| static void | ||
| expert_mode_toggle() |
Check notice
Code scanning / CodeQL
Unused static function Note
|
|
||
| static void | ||
| cb(tz_ui_cb_type_t cb_type) | ||
| blindsign_toggle() |
Check notice
Code scanning / CodeQL
Unused static function Note
* [format] add missing header guard to format.h file - plus add missing documentation * [sign] fix assertion for message type prints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developAdd blindsign settings. Allow to blindsign on stax via skip button . On nano after showing few
screens, switch to blindsign mode if blindsign setting is ON.