Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[summary] remove too long operation warning on parsing error #289

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[summary] remove too long operation warning on parsing error #289

merged 1 commit into from
Sep 23, 2024

Conversation

spalmer25
Copy link
Collaborator

fixes #288
This PR change the order of handlers:

At too long operation (that will not be parsed successfully),

Before:

  • Display too long operation warning screens
  • Then finish parsing

After:

  • Finish parsing
  • Then display too long operation warning screens

@spalmer25 spalmer25 added app::wallet issues relating to the wallet app device::NANOS Issues affecting NANOS device device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device labels Sep 19, 2024
@spalmer25 spalmer25 self-assigned this Sep 19, 2024
@spalmer25 spalmer25 force-pushed the paler@functori@remove-too-long-operation-warning-on-parsing-error branch 2 times, most recently from bc86485 to 300dd7e Compare September 19, 2024 13:34
@spalmer25 spalmer25 force-pushed the paler@functori@remove-too-long-operation-warning-on-parsing-error branch from 300dd7e to 2bef9fe Compare September 19, 2024 14:31
@spalmer25 spalmer25 marked this pull request as ready for review September 19, 2024 14:40
ajinkyaraj-23
ajinkyaraj-23 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalmer25 spalmer25 merged commit e871e20 into main Sep 23, 2024
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajinkyaraj-23 ajinkyaraj-23 ajinkyaraj-23 approved these changes

Assignees

@spalmer25 spalmer25

Labels
app::wallet issues relating to the wallet app device::NANOS Issues affecting NANOS device device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[summary] Remove too long operation warning on parsing error
2 participants
@spalmer25 @ajinkyaraj-23