continue-on-error foundations: refactor verification to a separate trait #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
added
breaking
Dentosal
changed the title
Dentosal
changed the title
6 tasks
Dentosal
requested review from
xgreenx,
MitchTurner and
Voxelot
as code owners
xgreenx
reviewed
Feb 25, 2025
fuel-vm/src/verification.rs
Outdated
Comment on lines
24
to
26
| where | ||
| Self: Sized + Seal, | ||
| S: InterpreterStorage, |
There was a problem hiding this comment.
Do we need S here at all? Based on the use cases that we discussed, it looks like we don't need it anymore=)
There was a problem hiding this comment.
True. Removed in 9cc0677.
Co-authored-by: Green Baneling <[email protected]>
Co-authored-by: Green Baneling <[email protected]>
Co-authored-by: Green Baneling <[email protected]>
Co-authored-by: Green Baneling <[email protected]>
Co-authored-by: Green Baneling <[email protected]>
Co-authored-by: Green Baneling <[email protected]>
xgreenx
previously approved these changes
Feb 26, 2025
xgreenx
approved these changes
Feb 26, 2025
rymnc
approved these changes
Feb 26, 2025
Merged
xgreenx
added a commit
to FuelLabs/fuel-core
that referenced
this pull request
Mar 12, 2025
…un (#2840) This change starts using the FuelLabs/fuel-vm#918 feature for the `asemble_tx` endpoint. --------- Co-authored-by: Mårten Blankfors <[email protected]> Co-authored-by: AurelienFT <[email protected]> Co-authored-by: Aaryamann Challani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #691
Follow-up: #915
Moves some parts of tx verification logic to a separate trait so it can be replaced. This initial PR only moves "is contract in inputs" check. More rules can be migrated as they are needed.
This is a breaking change, as we need to add a new type parameter to the VM. While the default value keeps the same behavior, existing trait implementations might still break.
The new trait is fully sealed: it cannot be implemented outside fuel-vm, and it's methods cannot be called outside it. This means adding or removing methods is not a breaking change in the future.
In addition, an internal
InputContractstype is removed and it's field flattened on the containing structs.Checklist
Before requesting review